Skip to content

Start jupyter notebooks even if notebook is not installed in currenv env #8977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2019

Conversation

DonJayamanne
Copy link

For #8951

Its possible notebook module is not installed in current interpreter.

  • If this is the case do not use daemon to startnotebook
  • Also change how we get list of notebooks running in getServerInfo.py

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Dec 10, 2019
@DonJayamanne
Copy link
Author

Because CI sucks

@codecov-io
Copy link

codecov-io commented Dec 10, 2019

Codecov Report

Merging #8977 into master will increase coverage by <.01%.
The diff coverage is 59.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8977      +/-   ##
==========================================
+ Coverage   58.17%   58.17%   +<.01%     
==========================================
  Files         529      529              
  Lines       27729    27745      +16     
  Branches     4178     4181       +3     
==========================================
+ Hits        16132    16142      +10     
  Misses      10705    10705              
- Partials      892      898       +6
Impacted Files Coverage Δ
src/client/datascience/jupyter/jupyterCommand.ts 69.23% <41.66%> (-4.69%) ⬇️
...lient/datascience/jupyter/kernels/kernelService.ts 57.31% <80%> (+1.9%) ⬆️
src/client/common/utils/version.ts 81.48% <0%> (ø) ⬆️
.../client/datascience/jupyter/jupyterConnectError.ts 75% <0%> (ø) ⬆️
src/client/datascience/cellFactory.ts 71.25% <0%> (ø) ⬆️
src/client/providers/providerUtilities.ts 88.88% <0%> (ø) ⬆️
src/client/constants.ts 80% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acb59d3...21f2795. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 7e70cb2 into microsoft:master Dec 10, 2019
@DonJayamanne DonJayamanne deleted the fixKernelStuff branch December 17, 2019 17:30
@lock lock bot locked as resolved and limited conversation to collaborators Dec 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants