Use the autoStart server if it matches when starting a new server #9929
Conversation
| @@ -43,7 +44,7 @@ export class ServerCache implements IAsyncDisposable { | |||
|
|
|||
| // See if the old options had the same UI setting. If not, | |||
| // cancel the old | |||
| if (data && data.options.disableUI !== fixedOptions.disableUI) { | |||
There was a problem hiding this comment.
the autostart server always has disableUI set to true.
| @@ -75,6 +77,12 @@ export class ServerCache implements IAsyncDisposable { | |||
| return oldDispose(); | |||
| }; | |||
|
|
|||
| // We've resolved the promise at this point | |||
| const resolvedData = this.cache.get(key); | |||
There was a problem hiding this comment.
I don't think you need to get it from the cache again. The local variable 'data' should work too, no?
There was a problem hiding this comment.
Hmm, you know, looking at it, it should be there. I was debugging and didn't have "data" available in the debug console. Lemme try it quick and see.
There was a problem hiding this comment.
@rchiodo right you are. changing quick. Wonder why the debugger didn't see it?
There was a problem hiding this comment.
Who knows. It can be pretty flakey with data on the stack.
In reply to: 375531583 [](ancestors = 375531583)
There was a problem hiding this comment.
Might be in one of the other 'closure' entries.
In reply to: 375531898 [](ancestors = 375531898,375531583)
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #9929 +/- ##
==========================================
- Coverage 61.22% 61.21% -0.01%
==========================================
Files 563 564 +1
Lines 30058 30063 +5
Branches 4545 4546 +1
==========================================
+ Hits 18403 18404 +1
- Misses 10626 10629 +3
- Partials 1029 1030 +1
Continue to review full report at Codecov.
|
…crosoft#9929) * don't cancel an already resolve servercache just due to disableUI changes * don't pull data a second time
For #9926
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).