Skip to content

Commit 51a2b03

Browse files
authored
Make --verbosity case insensitive (#2300)
Fixes #2179
1 parent f919e24 commit 51a2b03

File tree

2 files changed

+22
-2
lines changed

2 files changed

+22
-2
lines changed

src/Microsoft.TestPlatform.Build/Tasks/VSTestTask.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -247,11 +247,11 @@ private List<string> AddArgs()
247247
var quietTestLogging = new List<string>() {"q", "quiet"};
248248

249249
string vsTestVerbosity = "minimal";
250-
if (normalTestLogging.Contains(this.VSTestVerbosity))
250+
if (normalTestLogging.Contains(this.VSTestVerbosity.ToLowerInvariant()))
251251
{
252252
vsTestVerbosity = "normal";
253253
}
254-
else if (quietTestLogging.Contains(this.VSTestVerbosity))
254+
else if (quietTestLogging.Contains(this.VSTestVerbosity.ToLowerInvariant()))
255255
{
256256
vsTestVerbosity = "quiet";
257257
}

test/Microsoft.TestPlatform.Build.UnitTests/VsTestTaskTests.cs

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,26 @@ public void CreateArgumentShouldSetConsoleLoggerVerbosityToMinimalIfConsoleLogge
188188
Assert.IsNotNull(allArguments.FirstOrDefault(arg => arg.Contains("--logger:Console;Verbosity=minimal")));
189189
}
190190

191+
[TestMethod]
192+
public void CreateArgumentShouldSetConsoleLoggerVerbosityToNormalIfConsoleLoggerIsNotGivenInArgsAndVerbosityIsNormalWithCapitalN()
193+
{
194+
this.vsTestTask.VSTestVerbosity = "Normal";
195+
196+
var allArguments = this.vsTestTask.CreateArgument().ToArray();
197+
198+
Assert.IsNotNull(allArguments.FirstOrDefault(arg => arg.Contains("--logger:Console;Verbosity=normal")));
199+
}
200+
201+
[TestMethod]
202+
public void CreateArgumentShouldSetConsoleLoggerVerbosityToQuietIfConsoleLoggerIsNotGivenInArgsAndVerbosityIsQuietWithCapitalQ()
203+
{
204+
this.vsTestTask.VSTestVerbosity = "Quiet";
205+
206+
var allArguments = this.vsTestTask.CreateArgument().ToArray();
207+
208+
Assert.IsNotNull(allArguments.FirstOrDefault(arg => arg.Contains("--logger:Console;Verbosity=quiet")));
209+
}
210+
191211
[TestMethod]
192212
public void CreateArgumentShouldPreserveWhiteSpaceInLogger()
193213
{

0 commit comments

Comments
 (0)