Explicity name default values

Author: samwelkanda

msgraph/core/_client_factory.py

@@ -6,7 +6,7 @@
 
 from requests import Session
 
-from ._constants import CONNECTION_TIMEOUT, REQUEST_TIMEOUT
+from ._constants import DEFAULT_CONNECTION_TIMEOUT, DEFAULT_REQUEST_TIMEOUT
 from ._enums import APIVersion, NationalClouds
 from .middleware.abc_token_credential import TokenCredential
 from .middleware.authorization import AuthorizationHandler
@@ -37,7 +37,7 @@ def __init__(self, **kwargs):
         to configure the request handling behaviour of the client"""
         self.api_version = kwargs.get('api_version', APIVersion.v1)
         self.endpoint = kwargs.get('cloud', NationalClouds.Global)
-        self.timeout = kwargs.get('timeout', (CONNECTION_TIMEOUT, REQUEST_TIMEOUT))
+        self.timeout = kwargs.get('timeout', (DEFAULT_CONNECTION_TIMEOUT, DEFAULT_REQUEST_TIMEOUT))
         self.session = kwargs.get('session', Session())
 
         self._set_base_url()

msgraph/core/_constants.py

@@ -3,9 +3,9 @@
 # Licensed under the MIT License.
 # ------------------------------------
 """
-Application constants
+Application constants. All defaults can be changed when initializing a client
+via the GraphClient or HttpClientFactory
 """
-REQUEST_TIMEOUT = 100
-CONNECTION_TIMEOUT = 30
-BASE_URL = 'https://graph.microsoft.com/'
+DEFAULT_REQUEST_TIMEOUT = 100
+DEFAULT_CONNECTION_TIMEOUT = 30
 SDK_VERSION = '0.1.0'

tests/unit/test_client_factory.py

@@ -7,7 +7,7 @@
 from requests.adapters import HTTPAdapter
 
 from msgraph.core import APIVersion, HTTPClientFactory, NationalClouds
-from msgraph.core._constants import CONNECTION_TIMEOUT, REQUEST_TIMEOUT
+from msgraph.core._constants import DEFAULT_CONNECTION_TIMEOUT, DEFAULT_REQUEST_TIMEOUT
 from msgraph.core.middleware.authorization import AuthorizationHandler
 
 
@@ -18,7 +18,7 @@ def test_initialize_with_default_config():
 
     assert client.api_version == APIVersion.v1
     assert client.endpoint == NationalClouds.Global
-    assert client.timeout == (CONNECTION_TIMEOUT, REQUEST_TIMEOUT)
+    assert client.timeout == (DEFAULT_CONNECTION_TIMEOUT, DEFAULT_REQUEST_TIMEOUT)
     assert isinstance(client.session, Session)
 
 

tests/unit/test_graph_client.py

@@ -8,7 +8,6 @@
 from requests.adapters import HTTPAdapter
 
 from msgraph.core import APIVersion, GraphClient, NationalClouds
-from msgraph.core._constants import CONNECTION_TIMEOUT, REQUEST_TIMEOUT
 from msgraph.core.middleware.authorization import AuthorizationHandler