Merge pull request swiftlang#68952 from tbkka/tbkka-rdar111422725-more-SwiftValue-casting

[Casting] Make more casts look inside `__SwiftValue`

Author: tbkka

stdlib/public/runtime/SwiftObject.mm

@@ -1093,6 +1093,22 @@ static bool isObjCForUnownedReference(void *value) {
   if (object == nullptr)
     return nullptr;
 
+  if ([id_const_cast(object) isKindOfClass:[__SwiftValue class]]) {
+    // Source is a `__SwiftValue` container
+    // Unwrap, then use the most general casting machine to do the heavy lifting
+    auto typeValue = getValueFromSwiftValue(reinterpret_cast<__SwiftValue *>(object));
+    const void *result = nullptr;
+    if (swift_dynamicCast(reinterpret_cast<OpaqueValue *>(&result),
+			  const_cast<OpaqueValue *>(typeValue.second),
+			  typeValue.first,
+			  targetType,
+			  DynamicCastFlags::TakeOnSuccess)) {
+      return result;
+    } else {
+      return nullptr;
+    }
+  }
+
   if ([id_const_cast(object) isKindOfClass:class_const_cast(targetType)]) {
     return object;
   }

test/Casting/Casts.swift

@@ -1064,4 +1064,21 @@ CastsTests.test("Don't put AnyHashable inside AnyObject") {
   expectTrue(a === d)
 }
 
+#if _runtime(_ObjC)
+CastsTests.test("__SwiftValue should not be obvious to `is`") {
+  struct S {}
+  let s = S() as AnyObject
+  expectFalse(s is NSObject)
+}
+#endif
+
+CastsTests.test("type(of:) should look through __SwiftValue")
+.xfail(.always("Known to be broken"))
+.code {
+  struct S {}
+  let s = S() as AnyObject
+  let t = "\(type(of: s))"
+  expectEqual(t, "S")  // Fails: currently says `__SwiftValue`
+}
+
 runAllTests()