Apply suggestions from code review

Co-authored-by: Evan Wilde <[email protected]>

Author: compnerd

Runtimes/Core/cmake/modules/DefaultSettings.cmake

@@ -40,15 +40,15 @@ if(APPLE)
   set(SwiftCore_ENABLE_FATALERROR_BACKTRACE_default ON)
   set(SwiftCore_ENABLE_RUNTIME_OS_VERSIONING ON)
   set(SwiftCore_ENABLE_OVERRIDABLE_RETAIN_RELEASE ON)
-  set(SwiftCore_ENABLE_CONCURRENCY NO)
+  set(SwiftCore_ENABLE_CONCURRENCY_default NO)
   set(SwiftCore_THREADING_PACKAGE "DARWIN")
   set(SwiftCore_ENABLE_PRESPECIALIZATION_default ON)
-  set(SwiftCore_CONCURRENCY_GLOBAL_EXECUTOR "dispatch")
+  set(SwiftCore_CONCURRENCY_GLOBAL_EXECUTOR_default "dispatch")
 elseif(CMAKE_SYSTEM_NAME STREQUAL "WASM")
   set(SwiftCore_OBJECT_FORMAT_default "elf")
   set(SwiftCore_THREADING_PACKAGE "NONE")
-  set(SwiftCore_ENABLE_CONCURRENCY NO)
-  set(SwiftCore_CONCURRENCY_GLOBAL_EXECUTOR "none")
+  set(SwiftCore_ENABLE_CONCURRENCY_default NO)
+  set(SwiftCore_CONCURRENCY_GLOBAL_EXECUTOR_default "none")
 elseif(LINUX OR ANDROID OR BSD)
   set(SwiftCore_OBJECT_FORMAT_default "elf")
   set(SwiftCore_ENABLE_FATALERROR_BACKTRACE_default ON)
@@ -58,15 +58,15 @@ elseif(LINUX OR ANDROID OR BSD)
   else()
     set(SwiftCore_THREADING_PACKAGE "PTHREADS")
   endif()
-  set(SwiftCore_ENABLE_CONCURRENCY NO)
-  set(SwiftCore_CONCURRENCY_GLOBAL_EXECUTOR "dispatch")
+  set(SwiftCore_ENABLE_CONCURRENCY_default NO)
+  set(SwiftCore_CONCURRENCY_GLOBAL_EXECUTOR_default "dispatch")
 elseif(WIN32)
   set(SwiftCore_OBJECT_FORMAT_default "coff")
   set(SwiftCore_THREADING_PACKAGE "WIN32")
   set(SwiftCore_ENABLE_FATALERROR_BACKTRACE_default ON)
   set(SwiftCore_ENABLE_PRESPECIALIZATION_default ON)
-  set(SwiftCore_ENABLE_CONCURRENCY YES)
-  set(SwiftCore_CONCURRENCY_GLOBAL_EXECUTOR "dispatch")
+  set(SwiftCore_ENABLE_CONCURRENCY_default NO)
+  set(SwiftCore_CONCURRENCY_GLOBAL_EXECUTOR_default "dispatch")
 endif()
 
 include("${SwiftCore_VENDOR_MODULE_DIR}/DefaultSettings.cmake" OPTIONAL)