Fix warnings in various benchmarks (swiftlang#14333)

Author: airspeedswift

benchmark/single-source/Combos.swift

@@ -18,7 +18,7 @@ public func run_Combos(_ N: Int) {
   var combos = [[Character]]()
 
   for _ in 1...10*N {
-    combos = combinations("ABCDEFGHIJ".characters, "0123456789".characters).map {
+    combos = combinations("ABCDEFGHIJ", "0123456789").map {
       return [$0] + [$1]
     }
 

benchmark/single-source/LuhnAlgoEager.swift

@@ -220,7 +220,7 @@ let combineDoubleDigits = {
 // removing lazy at start of pipeline
 // switches to array-based version
 let eagerchecksum = { (ccnum: String) -> Bool in
-    ccnum.characters//.lazy
+    ccnum //.lazy
     |> { $0.reversed().lazy }
     |> { mapSome($0, charToInt) }
     |> { mapEveryN($0, 2, double) }

benchmark/single-source/LuhnAlgoLazy.swift

@@ -219,7 +219,7 @@ let combineDoubleDigits = {
 
 // first, the lazy version of checksum calcuation
 let lazychecksum = { (ccnum: String) -> Bool in
-    ccnum.characters.lazy
+    ccnum.lazy
     |> reverse
     |> { mapSome($0, charToInt) }
     |> { mapEveryN($0, 2, double) }

benchmark/single-source/NibbleSort.swift

@@ -38,8 +38,7 @@ struct NibbleCollection: RandomAccessCollection, MutableCollection {
   let startIndex: UInt64 = 0
   let endIndex: UInt64 = 16
 
-  subscript(bounds: Range<Index>)
-  -> MutableRandomAccessSlice<NibbleCollection> {
+  subscript(bounds: Range<Index>) -> Slice<NibbleCollection> {
     get {
       fatalError("Should not be called. Added here to please the type checker")
     }

benchmark/single-source/StringRemoveDupes.swift

@@ -24,12 +24,12 @@ public func run_StringRemoveDupes(_ N: Int) {
   for _ in 1...10*N {
     s = text.removeDuplicates()
 
-    if s.characters.count != textLengthRef {
+    if s.count != textLengthRef {
       break
     }
   }
 
-  CheckResults(s.characters.count == textLengthRef)
+  CheckResults(s.count == textLengthRef)
 }
 
 // removes all but first occurrence from a sequence, returning an array.
@@ -46,6 +46,6 @@ func uniq<S: Sequence,
 // all duplicates removed
 extension String {
   func removeDuplicates() -> String {
-    return String(uniq(self.characters))
+    return String(uniq(self))
   }
 }

stdlib/private/StdlibCollectionUnittest/CheckRangeReplaceableSliceType.swift

@@ -241,9 +241,9 @@ extension TestSuite {
       _ = c.removeLast() // Should trap.
     }
 
-    //===----------------------------------------------------------------------===//
+    //===------------------------------------------------------------------===//
     // removeLast(n: Int)
-    //===----------------------------------------------------------------------===//
+    //===------------------------------------------------------------------===//
 
     self.test("\(testNamePrefix).removeLast(n: Int)/semantics") {
       for test in removeLastTests {