Merge pull request #1617 from will-in-wi/rubocop_special_global_vars

Enable SpecialGlobalVars cop

Author: mikejohn857

.rubocop.yml

@@ -61,8 +61,6 @@ Style/Not:
   Enabled: false
 Style/RescueModifier:
   Enabled: false
-Style/SpecialGlobalVars:
-  Enabled: false
 Style/ModuleFunction:
   Enabled: false
 Style/BlockEndNewline:

capistrano.gemspec

@@ -12,7 +12,7 @@ Gem::Specification.new do |gem|
   gem.summary       = "Capistrano - Welcome to easy deployment with Ruby over SSH"
   gem.homepage      = "http://capistranorb.com/"
 
-  gem.files         = `git ls-files`.split($/)
+  gem.files         = `git ls-files -z`.split("\x0")
   gem.executables   = %w(cap capify)
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]

features/support/vagrant_helpers.rb

@@ -1,3 +1,5 @@
+require "English"
+
 module VagrantHelpers
   extend self
 
@@ -19,7 +21,7 @@ def vagrant_cli_command(command)
         puts "[vagrant] #{line}"
       end
     end
-    $?
+    $CHILD_STATUS
   end
 
   def run_vagrant_command(command)

spec/support/test_app.rb

@@ -1,3 +1,4 @@
+require "English"
 require "fileutils"
 require "pathname"
 
@@ -91,7 +92,7 @@ def run(command)
     Dir.chdir(test_app_path) do
       output = %x[#{command}]
     end
-    [$?.success?, output]
+    [$CHILD_STATUS.success?, output]
   end
 
   def stage