Merge pull request #1613 from will-in-wi/rubocop_raise_args

Enable RaiseArgs cop

Author: mikejohn857

.rubocop.yml

@@ -51,8 +51,6 @@ Style/Lambda:
   Enabled: false
 Style/EmptyLiteral:
   Enabled: false
-Style/RaiseArgs:
-  Enabled: false
 Style/SingleLineBlockParams:
   Enabled: false
 Style/Not:

lib/capistrano/configuration.rb

@@ -81,7 +81,7 @@ def is_question?(key)
 
     def role(name, hosts, options={})
       if name == :all
-        raise ArgumentError.new("#{name} reserved name for role. Please choose another name")
+        raise ArgumentError, "#{name} reserved name for role. Please choose another name"
       end
 
       servers.add_role(name, hosts, options)
@@ -179,7 +179,7 @@ def callable_without_parameters?(x)
 
     def invoke_validations(key, value, &block)
       unless value.nil? or block.nil?
-        raise Capistrano::ValidationError.new("Value and block both passed to Configuration#set")
+        raise Capistrano::ValidationError, "Value and block both passed to Configuration#set"
       end
 
       return unless validators.key? key

lib/capistrano/scm.rb

@@ -58,9 +58,7 @@ def fetch(*args)
     # @return [Boolean]
     #
     def test
-      raise NotImplementedError.new(
-        "Your SCM strategy module should provide a #test method"
-      )
+      raise NotImplementedError, "Your SCM strategy module should provide a #test method"
     end
 
     # @abstract
@@ -71,9 +69,7 @@ def test
     # @return [Boolean]
     #
     def check
-      raise NotImplementedError.new(
-        "Your SCM strategy module should provide a #check method"
-      )
+      raise NotImplementedError, "Your SCM strategy module should provide a #check method"
     end
 
     # @abstract
@@ -83,9 +79,7 @@ def check
     # @return void
     #
     def clone
-      raise NotImplementedError.new(
-        "Your SCM strategy module should provide a #clone method"
-      )
+      raise NotImplementedError, "Your SCM strategy module should provide a #clone method"
     end
 
     # @abstract
@@ -95,9 +89,7 @@ def clone
     # @return void
     #
     def update
-      raise NotImplementedError.new(
-        "Your SCM strategy module should provide a #update method"
-      )
+      raise NotImplementedError, "Your SCM strategy module should provide a #update method"
     end
 
     # @abstract
@@ -107,9 +99,7 @@ def update
     # @return void
     #
     def release
-      raise NotImplementedError.new(
-        "Your SCM strategy module should provide a #release method"
-      )
+      raise NotImplementedError, "Your SCM strategy module should provide a #release method"
     end
 
     # @abstract
@@ -119,9 +109,7 @@ def release
     # @return void
     #
     def fetch_revision
-      raise NotImplementedError.new(
-        "Your SCM strategy module should provide a #fetch_revision method"
-      )
+      raise NotImplementedError, "Your SCM strategy module should provide a #fetch_revision method"
     end
   end
 end