Merge pull request #1594 from will-in-wi/rubocop

Rubocop

Author: mikejohn857

.rubocop.yml

@@ -0,0 +1,103 @@
+AllCops:
+  DisplayCopNames: true
+  DisplayStyleGuide: true
+  TargetRubyVersion: 2.0
+
+Style/ClassAndModuleChildren:
+  Enabled: false
+Style/DoubleNegation:
+  Enabled: false
+Style/HashSyntax:
+  EnforcedStyle: hash_rockets
+Style/SpaceAroundEqualsInParameterDefault:
+  EnforcedStyle: no_space
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+Style/TrivialAccessors:
+  AllowPredicates: true
+
+# Need discussion
+Style/AndOr:
+  Enabled: false
+Style/Documentation:
+  Enabled: false
+Style/RedundantSelf:
+  Enabled: false
+Style/RedundantReturn:
+  Enabled: false
+Style/SpaceAfterComma:
+  Enabled: false
+Style/ParallelAssignment:
+  Enabled: false
+Style/RegexpLiteral:
+  Enabled: false
+Style/SignalException:
+  Enabled: false
+Performance/RedundantMerge:
+  Enabled: false
+Style/PercentLiteralDelimiters:
+  Enabled: false
+Style/BlockDelimiters:
+  Enabled: false
+Style/ConditionalAssignment:
+  Enabled: false
+Style/AlignParameters:
+  Enabled: false
+Style/IfUnlessModifier:
+  Enabled: false
+Style/Next:
+  Enabled: false
+Style/Lambda:
+  Enabled: false
+Style/EmptyLiteral:
+  Enabled: false
+Style/RaiseArgs:
+  Enabled: false
+Style/SingleLineBlockParams:
+  Enabled: false
+Style/Not:
+  Enabled: false
+Style/WhileUntilModifier:
+  Enabled: false
+Style/RescueModifier:
+  Enabled: false
+Style/SpecialGlobalVars:
+  Enabled: false
+Style/ModuleFunction:
+  Enabled: false
+Style/DotPosition:
+  Enabled: false
+Style/BlockEndNewline:
+  Enabled: false
+Style/MultilineBlockLayout:
+  Enabled: false
+Style/TrailingCommaInLiteral:
+  Enabled: false
+Style/Proc:
+  Enabled: false
+Style/CommandLiteral:
+  Enabled: false
+Style/AlignHash:
+  Enabled: false
+
+# Needs refactors
+Metrics/PerceivedComplexity:
+  Enabled: false
+Metrics/CyclomaticComplexity:
+  Enabled: false
+Metrics/MethodLength:
+  Enabled: false
+Style/PredicateName:
+  Enabled: false
+Metrics/LineLength:
+  Enabled: false
+Metrics/AbcSize:
+  Enabled: false
+Style/PerlBackrefs:
+  Enabled: false
+Metrics/ClassLength:
+  Enabled: false
+Metrics/ModuleLength:
+  Enabled: false
+Style/AccessorMethodName:
+  Enabled: false

Gemfile

@@ -1,9 +1,9 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 # Specify your gem's dependencies in capistrano.gemspec
 gemspec
 
 group :cucumber do
-  gem 'cucumber'
-  gem 'rspec', '~> 3.0.0'
+  gem "cucumber"
+  gem "rspec", "~> 3.0.0"
 end

bin/cap

@@ -1,3 +1,3 @@
 #!/usr/bin/env ruby
-require 'capistrano/all'
+require "capistrano/all"
 Capistrano::Application.new.run

capistrano.gemspec

@@ -1,31 +1,31 @@
 # -*- encoding: utf-8 -*-
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'capistrano/version'
+require "capistrano/version"
 
 Gem::Specification.new do |gem|
   gem.name          = "capistrano"
   gem.version       = Capistrano::VERSION
   gem.authors       = ["Tom Clements", "Lee Hambley"]
   gem.email         = ["[email protected]", "[email protected]"]
-  gem.description   = %q{Capistrano is a utility and framework for executing commands in parallel on multiple remote machines, via SSH.}
-  gem.summary       = %q{Capistrano - Welcome to easy deployment with Ruby over SSH}
+  gem.description   = "Capistrano is a utility and framework for executing commands in parallel on multiple remote machines, via SSH."
+  gem.summary       = "Capistrano - Welcome to easy deployment with Ruby over SSH"
   gem.homepage      = "http://capistranorb.com/"
 
   gem.files         = `git ls-files`.split($/)
-  gem.executables   = ['cap', 'capify']
+  gem.executables   = %w(cap capify)
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]
 
-  gem.licenses      = ['MIT']
+  gem.licenses      = ["MIT"]
 
-  gem.required_ruby_version = '>= 1.9.3'
-  gem.add_dependency 'airbrussh', '>= 1.0.0.beta1'
-  gem.add_dependency 'i18n'
-  gem.add_dependency 'rake', '>= 10.0.0'
-  gem.add_dependency 'sshkit', '>= 1.9.0.rc1'
+  gem.required_ruby_version = ">= 1.9.3"
+  gem.add_dependency "airbrussh", ">= 1.0.0.beta1"
+  gem.add_dependency "i18n"
+  gem.add_dependency "rake", ">= 10.0.0"
+  gem.add_dependency "sshkit", ">= 1.9.0.rc1"
 
-  gem.add_development_dependency 'rspec'
-  gem.add_development_dependency 'mocha'
-  gem.add_development_dependency 'rubocop'
+  gem.add_development_dependency "rspec"
+  gem.add_development_dependency "mocha"
+  gem.add_development_dependency "rubocop"
 end

features/step_definitions/assertions.rb

@@ -1,5 +1,5 @@
 Then(/^references in the remote repo are listed$/) do
-  expect(@output).to include('refs/heads/master')
+  expect(@output).to include("refs/heads/master")
 end
 
 Then(/^the shared path is created$/) do
@@ -18,7 +18,7 @@
 
 Then(/^directories referenced in :linked_files are created in shared$/) do
   dirs = TestApp.linked_files.map { |path| TestApp.shared_path.join(path).dirname }
-  dirs.each do | dir|
+  dirs.each do |dir|
     run_vagrant_command(test_dir_exists(dir))
   end
 end
@@ -49,25 +49,25 @@
 end
 
 Then(/^the deploy\.rb file is created$/) do
-  file = TestApp.test_app_path.join('config/deploy.rb')
+  file = TestApp.test_app_path.join("config/deploy.rb")
   expect(File.exist?(file)).to be true
 end
 
 Then(/^the default stage files are created$/) do
-  staging = TestApp.test_app_path.join('config/deploy/staging.rb')
-  production = TestApp.test_app_path.join('config/deploy/production.rb')
+  staging = TestApp.test_app_path.join("config/deploy/staging.rb")
+  production = TestApp.test_app_path.join("config/deploy/production.rb")
   expect(File.exist?(staging)).to be true
   expect(File.exist?(production)).to be true
 end
 
 Then(/^the tasks folder is created$/) do
-  path = TestApp.test_app_path.join('lib/capistrano/tasks')
+  path = TestApp.test_app_path.join("lib/capistrano/tasks")
   expect(Dir.exist?(path)).to be true
 end
 
 Then(/^the specified stage files are created$/) do
-  qa = TestApp.test_app_path.join('config/deploy/qa.rb')
-  production = TestApp.test_app_path.join('config/deploy/production.rb')
+  qa = TestApp.test_app_path.join("config/deploy/qa.rb")
+  production = TestApp.test_app_path.join("config/deploy/production.rb")
   expect(File.exist?(qa)).to be true
   expect(File.exist?(production)).to be true
 end
@@ -91,18 +91,18 @@
 end
 
 Then(/^the failure task will run$/) do
-  failed = TestApp.shared_path.join('failed')
+  failed = TestApp.shared_path.join("failed")
   run_vagrant_command(test_file_exists(failed))
 end
 
 Then(/^the failure task will not run$/) do
-  failed = TestApp.shared_path.join('failed')
+  failed = TestApp.shared_path.join("failed")
   expect { run_vagrant_command(test_file_exists(failed)) }
     .to raise_error(VagrantHelpers::VagrantSSHCommandError)
 end
 
 When(/^an error is raised$/) do
-  error = TestApp.shared_path.join('fail')
+  error = TestApp.shared_path.join("fail")
   run_vagrant_command(test_file_exists(error))
 end
 

features/step_definitions/cap_commands.rb

@@ -9,4 +9,3 @@
 When(/^I run "(.*?)"$/) do |command|
   @success, @output = TestApp.run(command)
 end
-

features/step_definitions/setup.rb

@@ -3,7 +3,7 @@
 end
 
 Given(/^servers with the roles app and web$/) do
-  vagrant_cli_command('up') rescue nil
+  vagrant_cli_command("up") rescue nil
 end
 
 Given(/^a linked file "(.*?)"$/) do |file|
@@ -24,27 +24,27 @@
 end
 
 Given(/^a custom task to generate a file$/) do
-  TestApp.copy_task_to_test_app('spec/support/tasks/database.rake')
+  TestApp.copy_task_to_test_app("spec/support/tasks/database.rake")
 end
 
 Given(/^a task which executes as root$/) do
-  TestApp.copy_task_to_test_app('spec/support/tasks/root.rake')
+  TestApp.copy_task_to_test_app("spec/support/tasks/root.rake")
 end
 
 Given(/config stage file has line "(.*?)"/) do |line|
   TestApp.append_to_deploy_file(line)
 end
 
 Given(/^the configuration is in a custom location$/) do
-  TestApp.move_configuration_to_custom_location('app')
+  TestApp.move_configuration_to_custom_location("app")
 end
 
 Given(/^a custom task that will simulate a failure$/) do
-  safely_remove_file(TestApp.shared_path.join('failed'))
-  TestApp.copy_task_to_test_app('spec/support/tasks/fail.rake')
+  safely_remove_file(TestApp.shared_path.join("failed"))
+  TestApp.copy_task_to_test_app("spec/support/tasks/fail.rake")
 end
 
 Given(/^a custom task to run in the event of a failure$/) do
-  safely_remove_file(TestApp.shared_path.join('failed'))
-  TestApp.copy_task_to_test_app('spec/support/tasks/failed.rake')
+  safely_remove_file(TestApp.shared_path.join("failed"))
+  TestApp.copy_task_to_test_app("spec/support/tasks/failed.rake")
 end

features/support/env.rb

@@ -1,11 +1,11 @@
-PROJECT_ROOT = File.expand_path('../../../', __FILE__)
-VAGRANT_ROOT = File.join(PROJECT_ROOT, 'spec/support')
-VAGRANT_BIN = ENV['VAGRANT_BIN'] || "vagrant"
+PROJECT_ROOT = File.expand_path("../../../", __FILE__)
+VAGRANT_ROOT = File.join(PROJECT_ROOT, "spec/support")
+VAGRANT_BIN = ENV["VAGRANT_BIN"] || "vagrant"
 
 at_exit do
-  if ENV['KEEP_RUNNING']
+  if ENV["KEEP_RUNNING"]
     VagrantHelpers.run_vagrant_command("rm -rf /home/vagrant/var")
   end
 end
 
-require_relative '../../spec/support/test_app'
+require_relative "../../spec/support/test_app"

features/support/remote_command_helpers.rb

@@ -1,14 +1,14 @@
 module RemoteCommandHelpers
   def test_dir_exists(path)
-    exists?('d', path)
+    exists?("d", path)
   end
 
   def test_symlink_exists(path)
-    exists?('L', path)
+    exists?("L", path)
   end
 
   def test_file_exists(path)
-    exists?('f', path)
+    exists?("f", path)
   end
 
   def exists?(type, path)

features/support/vagrant_helpers.rb

@@ -4,7 +4,7 @@ module VagrantHelpers
   class VagrantSSHCommandError < RuntimeError; end
 
   at_exit do
-    if ENV['KEEP_RUNNING']
+    if ENV["KEEP_RUNNING"]
       puts "Vagrant vm will be left up because KEEP_RUNNING is set."
       puts "Rerun without KEEP_RUNNING set to cleanup the vm."
     else
@@ -29,7 +29,6 @@ def run_vagrant_command(command)
       fail VagrantSSHCommandError, status
     end
   end
-
 end
 
 World(VagrantHelpers)

lib/Capfile

@@ -1,3 +1,3 @@
 #!/usr/bin/env cap
 include Capistrano::DSL
-require 'capistrano/install'
+require "capistrano/install"

lib/capistrano/all.rb

@@ -1,17 +1,16 @@
-require 'rake'
-require 'sshkit'
+require "rake"
+require "sshkit"
 
-require 'io/console'
+require "io/console"
 
 Rake.application.options.trace = true
 
-require 'capistrano/version'
-require 'capistrano/version_validator'
-require 'capistrano/i18n'
-require 'capistrano/dsl'
-require 'capistrano/application'
-require 'capistrano/configuration'
+require "capistrano/version"
+require "capistrano/version_validator"
+require "capistrano/i18n"
+require "capistrano/dsl"
+require "capistrano/application"
+require "capistrano/configuration"
 
 module Capistrano
-
 end