Skip to content

Commit 14ac3df

Browse files
Steven Gradycopybara-github
authored andcommitted
[roll] Roll fuchsia [ffx] Fix expiration of "ad-hoc" targets
If you make an ad-hoc connection (e.g. "ffx -t 1.2.3.4 target echo"), we will add 1.2.3.4 to the daemon's target collection, but due to incorrect logic, it gets an "expiration", which means that if we don't see any mDNS packets from that target (and there's no reason to expect any -- it wasn't "discovered"), then we eventually (after 25 seconds) expire the address. After which, the next request of "ffx -t 1.2.3.4 target echo" would not find the target by its address, and it would establish a second host-pipe connection. Then the daemon would wait for Overnet to inform it of the new connection, so it could try to establish an RCS connection. But from Overnet's point of view, there is no new target; it already knew about it. So the daemon never completes the RCS connection, resulting in a time-out in the client. The fix is simply to call it a "manual" target, with no expiry. Original-Bug: 392682202 Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1194236 Original-Revision: 74c1f638ff227ea78bcd886b6e72b1200d92c02f GitOrigin-RevId: 6b10c7566e720db89856d9cef23ad59cafcb67e5 Change-Id: Iddc8fd73ae8deef788478ebebe9b86dec493dc03
1 parent 88cb828 commit 14ac3df

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

stem

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
githooks="integration/git-hooks"
1212
remote="https://fuchsia.googlesource.com/fuchsia"
1313
gerrithost="https://fuchsia-review.googlesource.com"
14-
revision="30d11f7cd74bacb4a2e2622c5f6d14f9f25556c7"/>
14+
revision="74c1f638ff227ea78bcd886b6e72b1200d92c02f"/>
1515
</projects>
1616
<hooks>
1717
<hook name="install-environment"

0 commit comments

Comments
 (0)