Skip to content

Commit ce6ef72

Browse files
gulfemsavrunCQ Bot
authored andcommitted
[fxt] Add missing include for type_traits
llvm/llvm-project#97746 removed the transitive include of type_traits in libcxx, so we need to manually include that. Bug: 353654962 Change-Id: Ieacbfba52e08807c68b4791d35b40c8041496e5e Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1083432 Commit-Queue: Auto-Submit <[email protected]> Fuchsia-Auto-Submit: Gulfem Savrun Yeniceri <[email protected]> Reviewed-by: Gwen Mittertreiner <[email protected]>
1 parent 852692c commit ce6ef72

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/performance/lib/fxt/include/lib/fxt/interned_string.h

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
#include <zircon/types.h>
1111

1212
#include <atomic>
13+
#include <type_traits>
1314

1415
namespace fxt {
1516

@@ -110,8 +111,8 @@ struct InternedString {
110111
// resulting in every InternedString instance from instantiations of the _intern literal operator
111112
// being placed in the "__fxt_interned_string_table" section. However, GCC ignores section
112113
// attributes on COMDAT symbols as of this writing, resulting in an empty section when compiled
113-
// with GCC. TODO(https://fxbug.dev/42101573): Cleanup this comment when GCC supports section attributes on
114-
// COMDAT.
114+
// with GCC. TODO(https://fxbug.dev/42101573): Cleanup this comment when GCC supports section
115+
// attributes on COMDAT.
115116

116117
static void PreRegister() {
117118
for (const InternedString& interned_string : IterateSection) {
@@ -125,8 +126,8 @@ struct InternedString {
125126
static void SetMapStringCallback(MapStringCallback callback) { map_string_callback_ = callback; }
126127

127128
private:
128-
// TODO(https://fxbug.dev/42108473): Replace runtime lock-free linked list with comdat linker sections once
129-
// the toolchain supports it with all compilers.
129+
// TODO(https://fxbug.dev/42108473): Replace runtime lock-free linked list with comdat linker
130+
// sections once the toolchain supports it with all compilers.
130131
[[gnu::noinline]] static uint16_t Register(const InternedString& interned_string) {
131132
// Return the id if the string ref is already registered.
132133
uint16_t id = interned_string.id.load(std::memory_order_relaxed);

0 commit comments

Comments
 (0)