Skip to content

Commit a468bc7

Browse files
committed
perf: apply initial buffer size for bytes.Buffer
1 parent 7d44145 commit a468bc7

File tree

3 files changed

+12
-14
lines changed

3 files changed

+12
-14
lines changed

src/serverHandler/log.go

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,28 +5,24 @@ import (
55
"net/http"
66
)
77

8+
const LOG_BUF_SIZE = 80
9+
810
func (h *handler) logRequest(r *http.Request) {
911
if !h.logger.CanLogAccess() {
1012
return
1113
}
1214

13-
buffer := &bytes.Buffer{}
14-
15-
buffer.WriteString(r.RemoteAddr)
16-
buffer.WriteByte(' ')
17-
buffer.WriteString(r.Method)
18-
buffer.WriteByte(' ')
19-
buffer.WriteString(r.RequestURI)
15+
payload := []byte(r.RemoteAddr + " " + r.Method + " " + r.RequestURI)
2016

21-
h.logger.LogAccess(buffer.Bytes())
17+
h.logger.LogAccess(payload)
2218
}
2319

2420
func (h *handler) logUpload(filename, fsPath string, r *http.Request) {
2521
if !h.logger.CanLogAccess() {
2622
return
2723
}
2824

29-
buffer := &bytes.Buffer{}
25+
buffer := bytes.NewBuffer(make([]byte, 0, LOG_BUF_SIZE))
3026

3127
buffer.WriteString(r.RemoteAddr)
3228
buffer.WriteByte(' ')
@@ -43,7 +39,7 @@ func (h *handler) logArchive(filename, relPath string, r *http.Request) {
4339
return
4440
}
4541

46-
buffer := &bytes.Buffer{}
42+
buffer := bytes.NewBuffer(make([]byte, 0, LOG_BUF_SIZE))
4743

4844
buffer.WriteString(r.RemoteAddr)
4945
buffer.WriteByte(' ')

src/serverLog/logMan.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ import (
99
"time"
1010
)
1111

12+
const LOG_BUF_SIZE = 80
13+
1214
type logMan struct {
1315
filename string
1416
file *os.File
@@ -19,7 +21,7 @@ type logMan struct {
1921
}
2022

2123
func getLogEntry(payload []byte) []byte {
22-
buffer := &bytes.Buffer{}
24+
buffer := bytes.NewBuffer(make([]byte, 0, LOG_BUF_SIZE))
2325
buffer.WriteString(util.FormatTimeSecond(time.Now()))
2426
buffer.WriteByte(' ')
2527
buffer.Write(payload)

src/util/compareNumInStr.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,15 @@ func findCommonPrefix(prev, next string) int {
2323
}
2424

2525
func extractPrefixDigits(input string) (output string) {
26-
buf := bytes.Buffer{}
26+
buffer := bytes.NewBuffer(make([]byte, 0, 8))
2727
for i, length := 0, len(input); i < length; i++ {
2828
b := input[i]
2929
if b < '0' || b > '9' {
3030
break
3131
}
32-
buf.WriteByte(b)
32+
buffer.WriteByte(b)
3333
}
34-
return buf.String()
34+
return buffer.String()
3535
}
3636

3737
func CompareNumInStr(prev, next string) bool {

0 commit comments

Comments
 (0)