Skip to content

Commit ab282db

Browse files
committed
perf(tpl): find itemList before check has-delete class name
Find `.item-list` first, then check if it has class `has-delete`, instead of searching `.has-delete` for the whole document.
1 parent 0f591e0 commit ab282db

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed

src/tpl/assert/main.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,17 @@
4444
}
4545

4646
function enableNonRefreshDelete() {
47-
var itemList = document.querySelector('.item-list.has-deletable');
47+
var itemList = document.querySelector('.item-list');
4848
if (!itemList || !itemList.addEventListener) {
4949
return;
5050
}
51+
if (itemList.classList) {
52+
if (!itemList.classList.contains('has-deletable')) {
53+
return;
54+
}
55+
} else if (itemList.className.indexOf('has-deletable') < 0) {
56+
return;
57+
}
5158

5259
itemList.addEventListener('click', function (e) {
5360
if (e.defaultPrevented || !e.target || e.target.className.indexOf('delete') < 0) {

src/tpl/assert/main.js.go

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,17 @@ upload.addEventListener('dragleave', onDragLeave);
3939
upload.addEventListener('drop', onDrop);
4040
}
4141
function enableNonRefreshDelete() {
42-
var itemList = document.querySelector('.item-list.has-deletable');
42+
var itemList = document.querySelector('.item-list');
4343
if (!itemList || !itemList.addEventListener) {
4444
return;
4545
}
46+
if (itemList.classList) {
47+
if (!itemList.classList.contains('has-deletable')) {
48+
return;
49+
}
50+
} else if (itemList.className.indexOf('has-deletable') < 0) {
51+
return;
52+
}
4653
itemList.addEventListener('click', function (e) {
4754
if (e.defaultPrevented || !e.target || e.target.className.indexOf('delete') < 0) {
4855
return;

0 commit comments

Comments
 (0)