Add support for PHP 7.4, but drop support for below PHP 7.1 #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way, I don't know why the travis-ci tick is not appearing here, but the tests pass in CI: |
|
Sorry for the late response. Awesome pr! But can you please fix conflicts? |
|
@mlanin Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like in order to support PHP 7.4 (#22), there's a bit of an avalanche effect that in order to be able to run the tests in PHP 7.4, Mockery needs to be upgraded, and in turn PHPUnit needs to be updated to such a version that requires you to use
: voidreturn typehints insetUp(), thus requiring a PHP version of at least 7.1.In this PR I've done these upgrades and also changed the README to suggest people to require a not-yet-existing
^4.0version of this library, assuming this is a big breaking change that would require a major version bump.This PR is meant to replace #23 as a more comprehensive one that doesn't leave the repository in an untestable state for the newest PHP version it supports.