Skip to content

Commit 4ff4998

Browse files
authored
Rollup merge of rust-lang#140766 - sayantn:stabilize-keylocker, r=traviscross,tgross35
Stabilize keylocker This PR stabilizes the feature flag `keylocker_x86` (tracking issue rust-lang#134813). # Public API The 2 `x86` target features `kl` and `widekl`, and the associated intrinsics in stdarch. These target features are very specialized, and are only used to signal the presence of the corresponding CPU instruction. They don't have any nontrivial interaction with the ABI (contrary to something like AVX), and serve the only purpose of enabling 11 stdarch intrinsics, all of which have been implemented and propagated to rustc via a stdarch submodule update. Also, these were added way back in LLVM12, and as the minimum LLVM required for rustc is LLVM19, we are safe in that front too! # Associated PRs - rust-lang#134814 - rust-lang/stdarch#1706 - rust-lang#136831 (stdarch submodule update) - rust-lang/stdarch#1795 (stabilizing the runtime detection and intrinsics) - rust-lang#141964 (stdarch submodule update for the stabilization of the runtime detection and intrinsics) As all of the required tasks have been done (adding the target features to rustc, implementing their runtime detection in std_detect and implementing the associated intrinsics in core_arch), these target features can be stabilized now. cc ````@rust-lang/lang```` cc ````@rust-lang/libs-api```` for the intrinsics and runtime detection I don't think anyone else worked on this feature, so no one else to ping, maybe cc ````@Amanieu.```` I will send the reference pr soon.
2 parents 2254a83 + 971cea4 commit 4ff4998

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

core/src/lib.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,6 @@
190190
#![feature(aarch64_unstable_target_feature)]
191191
#![feature(arm_target_feature)]
192192
#![feature(hexagon_target_feature)]
193-
#![feature(keylocker_x86)]
194193
#![feature(loongarch_target_feature)]
195194
#![feature(mips_target_feature)]
196195
#![feature(powerpc_target_feature)]

0 commit comments

Comments
 (0)