Skip to content

fix: use find_library instead of assuming library extension #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

denis-ismailaj
Copy link
Collaborator

@denis-ismailaj denis-ismailaj commented Sep 15, 2023

The output library filenames are not necessarily libggml.so and libclip.so. For example, on macOS their extensions are dylib.

This change outputs libggml in the same directory as libclip, and uses find_library as a more standard way of finding the correct filenames.

@monatis
Copy link
Owner

monatis commented Sep 15, 2023

Good. I also added a build script for Linux, similar ones can be added for other platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants