Skip to content

feat(smoke-tests): test Setup.exe installer for on Windows COMPASS-8706 #6671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 10, 2025
Merged

feat(smoke-tests): test Setup.exe installer for on Windows COMPASS-8706 #6671

merged 4 commits into from
Feb 10, 2025

Conversation

kraenhansen
Copy link
Contributor

Description

Merging this PR will:

  1. Add a new windows-registry.ts exporting a query function callable to query the windows registry database.
  2. Implement the Windows Setup.exe installer.
  3. Arm CI to execute the smoke tests for the Windows Setup.exe installer (only running time-to-first-query for now).

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@kraenhansen kraenhansen self-assigned this Jan 31, 2025
@github-actions github-actions bot added the feat label Jan 31, 2025
@kraenhansen kraenhansen force-pushed the kh/smoke-test/windows-setup-installer branch from c5f2f10 to d18b196 Compare January 31, 2025 10:01
lerouxb
lerouxb reviewed Jan 31, 2025
View reviewed changes
@kraenhansen kraenhansen force-pushed the kh/smoke-test/windows-setup-installer branch from e1be952 to d2d22ad Compare February 6, 2025 11:05
@kraenhansen kraenhansen requested a review from lerouxb February 6, 2025 11:06
lerouxb
lerouxb approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@lerouxb lerouxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@kraenhansen kraenhansen force-pushed the kh/smoke-test/windows-setup-installer branch from d2d22ad to 82396ad Compare February 6, 2025 19:41
@kraenhansen
Copy link
Contributor Author

I've removed the commit which updates to the auto-update-from so we can get this merged.

@kraenhansen kraenhansen marked this pull request as ready for review February 6, 2025 20:40
@kraenhansen kraenhansen force-pushed the kh/smoke-test/windows-setup-installer branch from 82396ad to 7913f12 Compare February 7, 2025 11:30
@kraenhansen kraenhansen added the no release notes Fix or feature not for release notes label Feb 7, 2025
@kraenhansen
Copy link
Contributor Author

Merging as the remaining flakes on CI seem unrelated to the changes I'm proposing.

@kraenhansen kraenhansen merged commit 8f4b3bc into main Feb 10, 2025
6 of 7 checks passed
@kraenhansen kraenhansen deleted the kh/smoke-test/windows-setup-installer branch February 10, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lerouxb lerouxb lerouxb approved these changes

Assignees

@kraenhansen kraenhansen

Labels
feat no release notes Fix or feature not for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kraenhansen @lerouxb