chore(ci): set env var correctly on windows #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabaasit
commented
Jun 7, 2024
.github/workflows/check-test.yaml
Outdated
Comment on lines
32
to
36
| - name: Sets env vars | ||
| if: github.event_name == 'pull_request' | ||
| run: echo "SINCE_REF=remotes/origin/main" >> $GITHUB_ENV | ||
| run: | | ||
| echo "SINCE_REF=remotes/origin/main" >> $GITHUB_ENV # linux/mac | ||
| echo "SINCE_REF=remotes/origin/main" >> $env:GITHUB_ENV # windows |
There was a problem hiding this comment.
Not sure if i should split it based on the OS. Let me know what you think?
There was a problem hiding this comment.
probably that would be cleaner
addaleax
reviewed
Jun 7, 2024
addaleax
approved these changes
Jun 7, 2024
Did not know about this option. Its much cleaner :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Open Questions
Checklist