chore: code review comment re: static inline struct

addaleax · addaleax · commit 414f95e21631 · 2024-07-29T22:22:19.000+02:00
diff --git a/addon/openssl-crypto.cc b/addon/openssl-crypto.cc
@@ -359,7 +359,7 @@ bool sign_rsa(void* unused_ctx,
 }
 
 void* opensslsym(const char* name) {
-    static struct OwnProcessDylib {
+    struct OwnProcessDylib {
         bool initialized = false;
 #ifdef _WIN32
         HMODULE lib;
@@ -386,7 +386,8 @@ void* opensslsym(const char* name) {
             return reinterpret_cast<void*>(dlsym(lib, name));
         }
 #endif
-    } dl;
+    };
+    static OwnProcessDylib dl;
     if (!dl.lib) {
         throw new std::runtime_error("Could not open process handle");
     }

Original file line number	Diff line number	Diff line change
`@@ -359,7 +359,7 @@ bool sign_rsa(void* unused_ctx,`
`359`	`359`	`}`
`360`	`360`
`361`	`361`	`void* opensslsym(const char* name) {`
`362`		`- static struct OwnProcessDylib {`
	`362`	`+ struct OwnProcessDylib {`
`363`	`363`	`bool initialized = false;`
`364`	`364`	`#ifdef _WIN32`
`365`	`365`	`HMODULE lib;`
`@@ -386,7 +386,8 @@ void* opensslsym(const char* name) {`
`386`	`386`	`return reinterpret_cast<void*>(dlsym(lib, name));`
`387`	`387`	`}`
`388`	`388`	`#endif`
`389`		`- } dl;`
	`389`	`+ };`
	`390`	`+ static OwnProcessDylib dl;`
`390`	`391`	`if (!dl.lib) {`
`391`	`392`	`throw new std::runtime_error("Could not open process handle");`
`392`	`393`	`}`