add homebrew publish to build/publish

rose-m · rose-m · commit 1619c5da46eb · 2021-01-11T16:18:57.000+01:00
diff --git a/packages/build/src/github-repo.ts b/packages/build/src/github-repo.ts
@@ -111,8 +111,9 @@ export class GithubRepo {
       .catch(this._ignoreAlreadyExistsError);
   }
 
-  // Creates release notes and uploads assets if they are not yet uploaded to
-  // Github.
+  /**
+   * Creates release notes and uploads assets if they are not yet uploaded to Github.
+   */
   async releaseToGithub(artifact: TarballFile, config: Config): Promise<void> {
     const tag = `v${config.version}`;
 
@@ -204,6 +205,27 @@ export class GithubRepo {
     return `https://jira.mongodb.org/issues/?jql=project%20%3D%20MONGOSH%20AND%20fixVersion%20%3D%20${version}`;
   }
 
+  async createPullRequest(title: string, fromBranch: string, toBaseBranch: string): Promise<{prNumber: number, url: string}> {
+    const response = await this.octokit.pulls.create({
+      ...this.repo,
+      base: toBaseBranch,
+      head: fromBranch,
+      title
+    });
+
+    return {
+      prNumber: response.data.number,
+      url: response.data.html_url
+    };
+  }
+
+  async mergePullRequest(prNumber: number): Promise<void> {
+    await this.octokit.pulls.merge({
+      ...this.repo,
+      pull_number: prNumber
+    });
+  }
+
   private _ignoreAlreadyExistsError(): (error: any) => Promise<void> {
     return (error: any): Promise<void> => {
       if (this._isAlreadyExistsError(error)) {
diff --git a/packages/build/src/homebrew/generate-formula.ts b/packages/build/src/homebrew/generate-formula.ts
@@ -1,12 +1,5 @@
-import { httpsSha256 } from './utils';
 
-export async function generateHomebrewFormula(version: string): Promise<string> {
-  const url = `https://registry.npmjs.org/@mongosh/cli-repl/-/cli-repl-${version}.tgz`;
-  const sha = await httpsSha256(url);
-  return renderFormula({ version, sha });
-}
-
-function renderFormula(context: { version: string, sha: string }): string {
+export function generateFormula(context: { version: string, sha: string }): string {
   return `require "language/node"
 
 class Mongosh < Formula
diff --git a/packages/build/src/homebrew/index.ts b/packages/build/src/homebrew/index.ts
@@ -0,0 +1,2 @@
+
+export * from './publish-to-homebrew';
diff --git a/packages/build/src/homebrew/publish-to-homebrew.ts b/packages/build/src/homebrew/publish-to-homebrew.ts
@@ -0,0 +1,27 @@
+import { GithubRepo } from '../github-repo';
+import { generateFormula } from './generate-formula';
+import { updateMongoDBTap } from './update-mongodb-tap';
+import { httpsSha256 } from './utils';
+
+const MONGO_HOMEBREW_REPO_URL = 'git@github.com:mongodb/homebrew-brew.git';
+
+export async function publishToHomebrew(tmpDir: string, mongoHomebrewRepo: GithubRepo, packageVersion: string): Promise<void> {
+  const cliReplPackageUrl = `https://registry.npmjs.org/@mongosh/cli-repl/-/cli-repl-${packageVersion}.tgz`;
+  const packageSha = await httpsSha256(cliReplPackageUrl);
+
+  const homebrewFormula = generateFormula({ version: packageVersion, sha: packageSha });
+  const tapBranch = await updateMongoDBTap({
+    tmpDir, packageVersion, packageSha, homebrewFormula,
+    mongoHomebrewRepoUrl: MONGO_HOMEBREW_REPO_URL
+  });
+
+  if (!tapBranch) {
+    console.warn('There are no changes to the homebrew formula');
+    return;
+  }
+
+  const pr = await mongoHomebrewRepo.createPullRequest(`mongosh ${packageVersion}`, tapBranch, 'master');
+  console.info(`Created PR #${pr.prNumber} in mongodb/homebrew-brew: ${pr.url}`);
+  await mongoHomebrewRepo.mergePullRequest(pr.prNumber);
+  console.info('-> Merged, homebrew formula is released');
+}
diff --git a/packages/build/src/homebrew/update-mongodb-tap.spec.ts b/packages/build/src/homebrew/update-mongodb-tap.spec.ts
@@ -30,7 +30,7 @@ describe('Homebrew update-mongodb-tap', () => {
       homebrewFormula: 'updated formula',
       mongoHomebrewRepoUrl: `file://${repoDir.path}`
     });
-    expect(updated).to.equal(true);
+    expect(updated).to.equal('mongosh-1.0.0-sha');
 
     execSync('git checkout mongosh-1.0.0-sha', { cwd: repoDir.path });
     expect(readFileSync(mongoshFormulaFile, 'utf-8')).to.equal('updated formula');
@@ -44,7 +44,7 @@ describe('Homebrew update-mongodb-tap', () => {
       homebrewFormula: 'formula',
       mongoHomebrewRepoUrl: `file://${repoDir.path}`
     });
-    expect(updated).to.equal(false);
+    expect(updated).to.equal(undefined);
 
     const branches = execSync('git branch -a', { cwd: repoDir.path }).toString().trim();
     expect(branches).to.equal('* master');
diff --git a/packages/build/src/homebrew/update-mongodb-tap.ts b/packages/build/src/homebrew/update-mongodb-tap.ts
@@ -9,11 +9,15 @@ export interface UpdateMongoDBTapParameters {
     packageSha: string;
     homebrewFormula: string;
     tmpDir: string;
-    mongoHomebrewRepoUrl?: string;
+    mongoHomebrewRepoUrl: string;
 }
 
-export async function updateMongoDBTap(params: UpdateMongoDBTapParameters): Promise<boolean> {
-  const repoUrl = params.mongoHomebrewRepoUrl || 'git@github.com:mongodb/homebrew-brew.git';
+/**
+ * Updates the mongosh formula in the given homebrew tap repository and returns the
+ * name of the branch pushed to the repository.
+ */
+export async function updateMongoDBTap(params: UpdateMongoDBTapParameters): Promise<string | undefined> {
+  const repoUrl = params.mongoHomebrewRepoUrl;
   const cloneDir = path.resolve(params.tmpDir, 'homebrew-brew');
   cloneRepository(cloneDir, repoUrl);
 
@@ -24,14 +28,13 @@ export async function updateMongoDBTap(params: UpdateMongoDBTapParameters): Prom
 
   const currentContent = await fs.readFile(formulaPath, 'utf-8');
   if (currentContent === params.homebrewFormula) {
-    console.warn('There are no changes to the homebrew formula');
-    return false;
+    return undefined;
   }
 
   await fs.writeFile( formulaPath, params.homebrewFormula, 'utf-8');
 
   execSync('git add .', { cwd: cloneDir, stdio: 'inherit' });
   execSync(`git commit -m "mongosh ${version}"`, { cwd: cloneDir, stdio: 'inherit' });
   execSync(`git push origin ${branchName}`, { cwd: cloneDir, stdio: 'inherit' });
-  return true;
+  return branchName;
 }
diff --git a/packages/build/src/publish.spec.ts b/packages/build/src/publish.spec.ts
@@ -1,9 +1,10 @@
-import { GithubRepo } from './github-repo';
-import publish from './publish';
 import chai, { expect } from 'chai';
-import Config from './config';
 import path from 'path';
 import sinon from 'ts-sinon';
+import Config from './config';
+import { GithubRepo } from './github-repo';
+import type { publishToHomebrew as publishToHomebrewType } from './homebrew';
+import publish from './publish';
 
 chai.use(require('sinon-chai'));
 
@@ -14,7 +15,9 @@ function createStubRepo(overrides?: any): GithubRepo {
 describe('publish', () => {
   let config: Config;
   let uploadDownloadCenterConfig: (version: string, awsKey: string, awsSecret: string) => Promise<any>;
+  let publishToHomebrew: typeof publishToHomebrewType;
   let githubRepo: GithubRepo;
+  let mongoHomebrewRepo: GithubRepo;
 
   beforeEach(() => {
     config = {
@@ -48,7 +51,9 @@ describe('publish', () => {
     };
 
     uploadDownloadCenterConfig = sinon.spy();
+    publishToHomebrew = sinon.spy();
     githubRepo = createStubRepo();
+    mongoHomebrewRepo = createStubRepo();
   });
 
   context('if is a public release', () => {
@@ -62,7 +67,9 @@ describe('publish', () => {
       await publish(
         config,
         githubRepo,
-        uploadDownloadCenterConfig
+        mongoHomebrewRepo,
+        uploadDownloadCenterConfig,
+        publishToHomebrew
       );
 
       expect(uploadDownloadCenterConfig).to.have.been.calledWith(
@@ -76,11 +83,30 @@ describe('publish', () => {
       await publish(
         config,
         githubRepo,
-        uploadDownloadCenterConfig
+        mongoHomebrewRepo,
+        uploadDownloadCenterConfig,
+        publishToHomebrew
       );
 
       expect(githubRepo.promoteRelease).to.have.been.calledWith(config);
     });
+
+    it('publishes to homebrew', async() => {
+      await publish(
+        config,
+        githubRepo,
+        mongoHomebrewRepo,
+        uploadDownloadCenterConfig,
+        publishToHomebrew
+      );
+
+      expect(publishToHomebrew).to.have.been.calledWith(
+        path.resolve(config.rootDir, 'tmp'),
+        mongoHomebrewRepo,
+        config.version
+      );
+      expect(publishToHomebrew).to.have.been.calledAfter(githubRepo.promoteRelease as any);
+    });
   });
 
   context('if is not a public release', () => {
@@ -94,7 +120,9 @@ describe('publish', () => {
       await publish(
         config,
         githubRepo,
-        uploadDownloadCenterConfig
+        mongoHomebrewRepo,
+        uploadDownloadCenterConfig,
+        publishToHomebrew
       );
 
       expect(uploadDownloadCenterConfig).not.to.have.been.called;
@@ -104,10 +132,24 @@ describe('publish', () => {
       await publish(
         config,
         githubRepo,
-        uploadDownloadCenterConfig
+        mongoHomebrewRepo,
+        uploadDownloadCenterConfig,
+        publishToHomebrew
       );
 
       expect(githubRepo.promoteRelease).not.to.have.been.called;
     });
+
+    it('does not publish to homebrew', async() => {
+      await publish(
+        config,
+        githubRepo,
+        mongoHomebrewRepo,
+        uploadDownloadCenterConfig,
+        publishToHomebrew
+      );
+
+      expect(publishToHomebrew).not.to.have.been.called;
+    });
   });
 });
diff --git a/packages/build/src/publish.ts b/packages/build/src/publish.ts
@@ -1,26 +1,36 @@
-import { GithubRepo } from './github-repo';
 import Config from './config';
+import { GithubRepo } from './github-repo';
 import { redactConfig } from './redact-config';
+import type { publishToHomebrew as publishToHomebrewType } from './homebrew';
+import path from 'path';
 
 export default async function publish(
   config: Config,
-  githubRepo: GithubRepo,
-  uploadDownloadCenterConfig: (version: string, awsKey: string, awsSecret: string) => Promise<any>
+  mongoshGithubRepo: GithubRepo,
+  mongoHomebrewGithubRepo: GithubRepo,
+  uploadDownloadCenterConfig: (version: string, awsKey: string, awsSecret: string) => Promise<any>,
+  publishToHomebrew: typeof publishToHomebrewType
 ): Promise<void> {
   console.info(
     'mongosh: beginning publish release with config:',
     redactConfig(config)
   );
 
-  if (!await githubRepo.shouldDoPublicRelease(config)) return;
+  if (!await mongoshGithubRepo.shouldDoPublicRelease(config)) return;
 
   await uploadDownloadCenterConfig(
     config.version,
     config.downloadCenterAwsKey || '',
     config.downloadCenterAwsSecret || ''
   );
 
-  await githubRepo.promoteRelease(config);
+  await mongoshGithubRepo.promoteRelease(config);
+
+  await publishToHomebrew(
+    path.resolve(config.rootDir, 'tmp'),
+    mongoHomebrewGithubRepo,
+    config.version
+  );
 
   console.info('mongosh: finished release process.');
 }
diff --git a/packages/build/src/release.ts b/packages/build/src/release.ts
@@ -1,20 +1,22 @@
-import compileExec, { executablePath } from './compile-exec';
-import { createTarball, TarballFile } from './tarball';
-import Platform from './platform';
+/* eslint-disable no-shadow */
+import { Octokit } from '@octokit/rest';
+import { promises as fs } from 'fs';
 import os from 'os';
 import path from 'path';
-import { promises as fs } from 'fs';
-import macOSSignAndNotarize from './macos-sign';
-import uploadToDownloadCenter from './upload-to-download-center';
+import { Barque } from './barque';
+import compileExec, { executablePath } from './compile-exec';
+import Config from './config';
+import doUpload from './do-upload';
 import uploadDownloadCenterConfig from './download-center';
 import uploadArtifactToEvergreen from './evergreen';
-import doUpload from './do-upload';
 import { GithubRepo } from './github-repo';
-import { Octokit } from '@octokit/rest';
-import { Barque } from './barque';
+import { publishToHomebrew } from './homebrew';
+import macOSSignAndNotarize from './macos-sign';
+import Platform from './platform';
 import publish from './publish';
 import { redactConfig } from './redact-config';
-import Config from './config';
+import { createTarball, TarballFile } from './tarball';
+import uploadToDownloadCenter from './upload-to-download-center';
 
 /**
  * Run the release process.
@@ -31,6 +33,7 @@ export default async function release(
   });
 
   const githubRepo = new GithubRepo(config.repo, octokit);
+  const mongoHomebrewRepo = new GithubRepo({ owner: 'mongodb', repo: 'homebrew-brew' }, octokit);
   const barque = new Barque(config);
   let tarballFile: TarballFile;
 
@@ -80,7 +83,9 @@ export default async function release(
     await publish(
       config,
       githubRepo,
-      uploadDownloadCenterConfig
+      mongoHomebrewRepo,
+      uploadDownloadCenterConfig,
+      publishToHomebrew
     );
   } else {
     throw new Error(`Unknown command: ${command}`);

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+`
	`2`	`+export * from './publish-to-homebrew';`