feat(node-runtime-worker-thread): Allow to configure spawn options of the child process created by worker runtime

Author: gribnoysup

packages/node-runtime-worker-thread/src/child-process-evaluation-listener.ts

@@ -0,0 +1,36 @@
+import { ChildProcess } from 'child_process';
+import { EvaluationListener } from '@mongosh/shell-evaluator';
+import { exposeAll, WithClose } from './rpc';
+import type { WorkerRuntime } from './index';
+
+export class ChildProcessEvaluationListener {
+  exposedListener: WithClose<EvaluationListener>;
+
+  constructor(workerRuntime: WorkerRuntime, childProcess: ChildProcess) {
+    this.exposedListener = exposeAll<EvaluationListener>(
+      {
+        onPrompt(question, type) {
+          return (
+            workerRuntime.evaluationListener?.onPrompt?.(question, type) ?? ''
+          );
+        },
+        onPrint(values) {
+          return workerRuntime.evaluationListener?.onPrint?.(values);
+        },
+        toggleTelemetry(enabled) {
+          return workerRuntime.evaluationListener?.toggleTelemetry?.(enabled);
+        },
+        onClearCommand() {
+          return workerRuntime.evaluationListener?.onClearCommand?.();
+        },
+        onExit() {
+          return (
+            workerRuntime.evaluationListener?.onExit?.() ??
+            (Promise.resolve() as Promise<never>)
+          );
+        }
+      },
+      childProcess
+    );
+  }
+}

packages/node-runtime-worker-thread/src/index.ts

@@ -1,57 +1,26 @@
 import { once } from 'events';
-import { ChildProcess } from 'child_process';
+import { ChildProcess, SpawnOptionsWithoutStdio } from 'child_process';
 import { MongoClientOptions } from '@mongosh/service-provider-core';
 import { Runtime } from '@mongosh/browser-runtime-core';
 import { EvaluationListener } from '@mongosh/shell-evaluator';
 import spawnChildFromSource from './spawn-child-from-source';
-import { Caller, createCaller, exposeAll, WithClose } from './rpc';
+import { Caller, createCaller } from './rpc';
+import { ChildProcessEvaluationListener } from './child-process-evaluation-listener';
 import type { WorkerRuntime as WorkerThreadWorkerRuntime } from './worker-runtime';
 import childProcessProxySrc from 'inline-entry-loader!./child-process-proxy';
 
 type ChildProcessRuntime = Caller<WorkerThreadWorkerRuntime>;
-
-class WorkerEvaluationListener {
-  exposedListener: WithClose<EvaluationListener>;
-
-  constructor(workerRuntime: WorkerRuntime, childProcess: ChildProcess) {
-    this.exposedListener = exposeAll<EvaluationListener>(
-      {
-        onPrompt(question, type) {
-          return (
-            workerRuntime.evaluationListener?.onPrompt?.(question, type) ?? ''
-          );
-        },
-        onPrint(values) {
-          return workerRuntime.evaluationListener?.onPrint?.(values);
-        },
-        toggleTelemetry(enabled) {
-          return workerRuntime.evaluationListener?.toggleTelemetry?.(enabled);
-        },
-        onClearCommand() {
-          return workerRuntime.evaluationListener?.onClearCommand?.();
-        },
-        onExit() {
-          return (
-            workerRuntime.evaluationListener?.onExit?.() ??
-            (Promise.resolve() as Promise<never>)
-          );
-        }
-      },
-      childProcess
-    );
-  }
-}
-
 class WorkerRuntime implements Runtime {
   private initOptions: {
     uri: string;
     driverOptions: MongoClientOptions;
     cliOptions: { nodb?: boolean };
+    spawnOptions: SpawnOptionsWithoutStdio;
   };
 
   evaluationListener: EvaluationListener | null = null;
 
-  private childProcessEvaluationListener!: WorkerEvaluationListener;
+  private childProcessEvaluationListener!: ChildProcessEvaluationListener;
 
   private childProcess!: ChildProcess;
 
@@ -62,27 +31,31 @@ class WorkerRuntime implements Runtime {
   constructor(
     uri: string,
     driverOptions: MongoClientOptions = {},
-    cliOptions: { nodb?: boolean } = {}
+    cliOptions: { nodb?: boolean } = {},
+    spawnOptions: SpawnOptionsWithoutStdio = {}
   ) {
-    this.initOptions = { uri, driverOptions, cliOptions };
+    this.initOptions = { uri, driverOptions, cliOptions, spawnOptions };
     this.initWorkerPromise = this.initWorker();
   }
 
   private async initWorker() {
-    this.childProcess = await spawnChildFromSource(childProcessProxySrc);
+    const { uri, driverOptions, cliOptions, spawnOptions } = this.initOptions;
+
+    this.childProcess = await spawnChildFromSource(
+      childProcessProxySrc,
+      spawnOptions
+    );
 
     this.childProcessRuntime = createCaller(
       ['init', 'evaluate', 'getCompletions', 'setEvaluationListener'],
       this.childProcess
     );
 
-    this.childProcessEvaluationListener = new WorkerEvaluationListener(
+    this.childProcessEvaluationListener = new ChildProcessEvaluationListener(
       this,
       this.childProcess
     );
 
-    const { uri, driverOptions, cliOptions } = this.initOptions;
-
     await this.childProcessRuntime.init(uri, driverOptions, cliOptions);
   }