refactor(node-runtime-worker-thread): Use nullish coalescing instead of if statement, fix typos

Co-authored-by: Anna Henningsen <[email protected]>

Author: gribnoysup

packages/node-runtime-worker-thread/package.json

@@ -14,7 +14,7 @@
     "url": "https://github.com/mongodb-js/mongosh"
   },
   "engines": {
-    "node": "^12.4.0"
+    "node": ">=12.4.0"
   },
   "scripts": {
     "pretest": "npm run webpack-build-dev -- --no-stats --no-devtool",

packages/node-runtime-worker-thread/src/child-process-proxy.ts

@@ -40,9 +40,9 @@ const worker = createCaller(
 
 function waitForWorkerReadyProxy<T extends Function>(fn: T): T {
   return new Proxy(fn, {
-    async apply(target, thisArg, argumetsList) {
+    async apply(target, thisArg, argumentsList) {
       await workerReadyPromise;
-      return target.call(thisArg, ...Array.from(argumetsList));
+      return target.call(thisArg, ...Array.from(argumentsList));
     }
   });
 }

packages/node-runtime-worker-thread/src/index.ts

@@ -16,33 +16,22 @@ class WorkerEvaluationListener {
     this.exposedListener = exposeAll<EvaluationListener>(
       {
         onPrompt(question, type) {
-          if (workerRuntime.evaluationListener?.onPrompt) {
-            return workerRuntime.evaluationListener.onPrompt(question, type);
-          }
-
-          return '';
+          return workerRuntime.evaluationListener.onPrompt?.(question, type) ?? '';
         },
-        onPrint(value) {
-          if (workerRuntime.evaluationListener?.onPrint) {
-            workerRuntime.evaluationListener.onPrint(value);
+        onPrint(values) {
+          return workerRuntime.evaluationListener?.onPrint?.(values);
           }
         },
         toggleTelemetry(enabled) {
-          if (workerRuntime.evaluationListener?.toggleTelemetry) {
-            workerRuntime.evaluationListener.toggleTelemetry(enabled);
+          return workerRuntime.evaluationListener?.toggleTelemetry?.(enabled);
           }
         },
         onClearCommand() {
-          if (workerRuntime.evaluationListener?.onClearCommand) {
-            workerRuntime.evaluationListener.onClearCommand();
-          }
+          return workerRuntime.evaluationListener.onClearCommand?.();
         },
         onExit() {
-          if (workerRuntime.evaluationListener?.onExit) {
-            return workerRuntime.evaluationListener.onExit();
-          }
-
-          return Promise.resolve() as Promise<never>;
+          return workerRuntime.evaluationListener?.onExit?.() ??
+            Promise.resolve() as Promise<never>;
         }
       },
       childProcess