wip remove publish-npm

Author: mcasimir

lerna.json

@@ -2,5 +2,5 @@
   "packages": [
     "packages/*"
   ],
-  "version": "0.6.1"
+  "version": "0.0.0-dev.0"
 }

packages/async-rewriter/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@mongosh/async-rewriter",
-  "version": "0.6.1",
+  "version": "0.0.0-dev.0",
   "description": "MongoDB Shell Async Rewriter Package",
   "main": "./lib/index.js",
   "scripts": {
@@ -32,7 +32,7 @@
     "@babel/template": "^7.8.6",
     "@babel/traverse": "^7.9.0",
     "@babel/types": "^7.9.0",
-    "@mongosh/errors": "^0.6.1",
+    "@mongosh/errors": "0.0.0-dev.0",
     "@types/babel__core": "^7.1.6",
     "@types/babel__traverse": "^7.0.9",
     "acorn": "^7.2.0",

packages/async-rewriter/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mongosh/autocomplete",
-  "version": "0.6.1",
+  "version": "0.0.0-dev.0",
   "description": "MongoDB Shell Autocomplete Package",
   "homepage": "https://github.com/mongodb-js/mongosh",
   "license": "Apache-2.0",
@@ -28,7 +28,7 @@
     "mocha": "^7.1.2"
   },
   "dependencies": {
-    "@mongosh/shell-api": "^0.6.1",
+    "@mongosh/shell-api": "0.0.0-dev.0",
     "mongodb-ace-autocompleter": "^0.4.14",
     "semver": "^7.3.2"
   }

packages/autocomplete/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@mongosh/browser-repl",
-  "version": "0.6.1",
+  "version": "0.0.0-dev.0",
   "description": "Browser presentation component for Mongo Shell",
   "engines": {
     "node": ">=12.4.0"
@@ -39,11 +39,11 @@
     "@leafygreen-ui/icon": "^4.0.0",
     "@leafygreen-ui/palette": "^2.0.0",
     "@leafygreen-ui/syntax": "^2.2.0",
-    "@mongosh/browser-runtime-core": "^0.6.1",
-    "@mongosh/history": "^0.6.1",
-    "@mongosh/i18n": "^0.6.1",
-    "@mongosh/service-provider-core": "^0.6.1",
-    "@mongosh/shell-evaluator": "^0.6.1",
+    "@mongosh/browser-runtime-core": "0.0.0-dev.0",
+    "@mongosh/history": "0.0.0-dev.0",
+    "@mongosh/i18n": "0.0.0-dev.0",
+    "@mongosh/service-provider-core": "0.0.0-dev.0",
+    "@mongosh/shell-evaluator": "0.0.0-dev.0",
     "pretty-bytes": "^5.3.0",
     "text-table": "^0.2.0"
   },

packages/autocomplete/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mongosh/browser-runtime-core",
-  "version": "0.6.1",
+  "version": "0.0.0-dev.0",
   "description": "Mongosh browser runtime core",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
@@ -29,17 +29,17 @@
     "access": "public"
   },
   "devDependencies": {
-    "@mongosh/types": "^0.6.1",
+    "@mongosh/types": "0.0.0-dev.0",
     "@types/babel__generator": "^7.6.2",
     "@types/babel__template": "^7.0.3",
     "rimraf": "^3.0.2"
   },
   "dependencies": {
     "@babel/generator": "^7.9.4",
     "@babel/parser": "^7.9.4",
-    "@mongosh/autocomplete": "^0.6.1",
-    "@mongosh/service-provider-core": "^0.6.1",
-    "@mongosh/shell-api": "^0.6.1",
-    "@mongosh/shell-evaluator": "^0.6.1"
+    "@mongosh/autocomplete": "0.0.0-dev.0",
+    "@mongosh/service-provider-core": "0.0.0-dev.0",
+    "@mongosh/shell-api": "0.0.0-dev.0",
+    "@mongosh/shell-evaluator": "0.0.0-dev.0"
   }
 }

packages/browser-repl/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@mongosh/browser-runtime-electron",
-  "version": "0.6.1",
+  "version": "0.0.0-dev.0",
   "description": "Mongosh browser runtime electron",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
@@ -29,13 +29,13 @@
     "access": "public"
   },
   "dependencies": {
-    "@mongosh/types": "^0.6.1",
-    "@mongosh/browser-runtime-core": "^0.6.1",
-    "@mongosh/service-provider-core": "^0.6.1",
-    "@mongosh/shell-evaluator": "^0.6.1"
+    "@mongosh/browser-runtime-core": "0.0.0-dev.0",
+    "@mongosh/service-provider-core": "0.0.0-dev.0",
+    "@mongosh/shell-evaluator": "0.0.0-dev.0",
+    "@mongosh/types": "0.0.0-dev.0"
   },
   "devDependencies": {
-    "@mongosh/service-provider-server": "^0.6.1",
+    "@mongosh/service-provider-server": "0.0.0-dev.0",
     "@types/sinon": "^7.5.1",
     "@types/sinon-chai": "^3.2.3",
     "rimraf": "^3.0.2"

packages/browser-repl/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mongosh/build",
-  "version": "0.6.1",
+  "version": "0.0.0-dev.0",
   "private": true,
   "description": "MongoDB Shell Build Tools",
   "main": "lib/index.js",

packages/browser-runtime-core/package-lock.json

@@ -1,5 +1,7 @@
-import { spawnSync } from 'child_process';
+import { execFileSync } from 'child_process';
 import path from 'path';
+import writeAnalyticsConfig from './analytics';
+import Config from './config';
 
 const PLACEHOLDER_VERSION = '0.0.0-dev.0';
 const PROJECT_ROOT = path.resolve(__dirname, '..', '..', '..');
@@ -10,7 +12,7 @@ export function bumpNpmPackages(version: string): void {
     return;
   }
 
-  spawnSync(LERNA_BIN, [
+  execFileSync(LERNA_BIN, [
     'version',
     version,
     '--no-changelog',
@@ -25,7 +27,13 @@ export function bumpNpmPackages(version: string): void {
   });
 }
 
-export function publishNpmPackages(): void {
+export async function publishNpmPackages(config: Config): Promise<void> {
+  // ensures the segment api key to be present in the published packages
+  await writeAnalyticsConfig(
+    config.analyticsConfigFilePath,
+    config.segmentKey
+  );
+
   const packages = listNpmPackages();
 
   const versions = Array.from(new Set(packages.map(({ version }) => version)));
@@ -38,7 +46,7 @@ export function publishNpmPackages(): void {
     throw new Error('Refusing to publish packages with placeholder version');
   }
 
-  spawnSync(LERNA_BIN, [
+  execFileSync(LERNA_BIN, [
     'publish',
     'from-package',
     '--no-changelog',
@@ -54,11 +62,11 @@ export function publishNpmPackages(): void {
 }
 
 function listNpmPackages(): {version: string}[] {
-  const lernaListOutput = spawnSync(
+  const lernaListOutput = execFileSync(
     LERNA_BIN, [
       '--json',
     ], { cwd: PROJECT_ROOT }
-  ).stdout.toString();
+  ).toString();
 
   const packages = JSON.parse(lernaListOutput);
   return packages;

packages/browser-runtime-core/package.json

@@ -14,6 +14,7 @@ function createStubRepo(overrides?: any): GithubRepo {
 describe('publish', () => {
   let config: Config;
   let uploadDownloadCenterConfig: (version: string, awsKey: string, awsSecret: string) => Promise<any>;
+  let publishNpmPackages: (config: Config) => Promise<void>;
   let githubRepo: GithubRepo;
 
   beforeEach(() => {
@@ -23,7 +24,7 @@ describe('publish', () => {
       input: 'input',
       execInput: 'execInput',
       outputDir: 'outputDir',
-      analyticsConfig: 'analyticsConfig',
+      analyticsConfigFilePath: 'analyticsConfigFilePath',
       project: 'project',
       revision: 'revision',
       branch: 'branch',
@@ -48,6 +49,7 @@ describe('publish', () => {
     };
 
     uploadDownloadCenterConfig = sinon.spy();
+    publishNpmPackages = sinon.spy();
     githubRepo = createStubRepo();
   });
 
@@ -62,7 +64,8 @@ describe('publish', () => {
       await publish(
         config,
         githubRepo,
-        uploadDownloadCenterConfig
+        uploadDownloadCenterConfig,
+        publishNpmPackages
       );
 
       expect(uploadDownloadCenterConfig).to.have.been.calledWith(
@@ -76,11 +79,23 @@ describe('publish', () => {
       await publish(
         config,
         githubRepo,
-        uploadDownloadCenterConfig
+        uploadDownloadCenterConfig,
+        publishNpmPackages
       );
 
       expect(githubRepo.promoteRelease).to.have.been.calledWith(config);
     });
+
+    it('publishes NPM packages', async() => {
+      await publish(
+        config,
+        githubRepo,
+        uploadDownloadCenterConfig,
+        publishNpmPackages
+      );
+
+      expect(publishNpmPackages).to.have.been.calledWith();
+    });
   });
 
   context('if is not a public release', () => {
@@ -94,7 +109,8 @@ describe('publish', () => {
       await publish(
         config,
         githubRepo,
-        uploadDownloadCenterConfig
+        uploadDownloadCenterConfig,
+        publishNpmPackages
       );
 
       expect(uploadDownloadCenterConfig).not.to.have.been.called;
@@ -104,10 +120,22 @@ describe('publish', () => {
       await publish(
         config,
         githubRepo,
-        uploadDownloadCenterConfig
+        uploadDownloadCenterConfig,
+        publishNpmPackages
       );
 
       expect(githubRepo.promoteRelease).not.to.have.been.called;
     });
+
+    it('does not publish npm packages', async() => {
+      await publish(
+        config,
+        githubRepo,
+        uploadDownloadCenterConfig,
+        publishNpmPackages
+      );
+
+      expect(publishNpmPackages).not.to.have.been.called;
+    });
   });
 });

packages/browser-runtime-electron/package-lock.json

@@ -1,12 +1,12 @@
 import { GithubRepo } from './github-repo';
 import Config from './config';
 import { redactConfig } from './redact-config';
-// import { publishNpmPackages } from './npm-packages';
 
 export default async function publish(
   config: Config,
   githubRepo: GithubRepo,
-  uploadDownloadCenterConfig: (version: string, awsKey: string, awsSecret: string) => Promise<any>
+  uploadDownloadCenterConfig: (version: string, awsKey: string, awsSecret: string) => Promise<any>,
+  publishNpmPackages: (config: Config) => Promise<void>,
 ): Promise<void> {
   console.info(
     'mongosh: beginning publish release with config:',
@@ -23,8 +23,6 @@ export default async function publish(
 
   await githubRepo.promoteRelease(config);
 
-  // publishNpmPackages();
+  await publishNpmPackages(config);
   console.info('mongosh: finished release process.');
 }
-
-

packages/browser-runtime-electron/package.json

@@ -16,7 +16,7 @@ import publish from './publish';
 import { redactConfig } from './redact-config';
 import Config from './config';
 import getReleaseVersionFromTag from './get-release-version-from-tag';
-import { bumpNpmPackages } from './npm-packages';
+import { bumpNpmPackages, publishNpmPackages } from './npm-packages';
 
 /**
  * Run the release process.
@@ -92,7 +92,8 @@ export default async function release(
     await publish(
       config,
       githubRepo,
-      uploadDownloadCenterConfig
+      uploadDownloadCenterConfig,
+      publishNpmPackages
     );
   } else {
     throw new Error(`Unknown command: ${command}`);