address comments except for env

Author: baileympearson

node/generate_release.js renamed to node/generate_release.mjs

@@ -1,5 +1,8 @@
-const { readFileSync } = require("fs");
-const { join } = require("path");
+import { readFileSync } from 'node:fs';
+import { join, dirname } from 'node:path';
+import { fileURLToPath } from 'node:url';
+    
+const __dirname = dirname(fileURLToPath(import.meta.url));
 
 const args = process.argv.slice(2);
 if (!(args.length === 3 || args.length === 4)) {
@@ -9,10 +12,10 @@ if (!(args.length === 3 || args.length === 4)) {
   process.exit(1);
 }
 
-const [package, branch, tag, assetGroup] = args;
+const [npmPackage, branch, tag, assetGroup] = args;
 
 const isNative =
-  package === "kerberos" || package === "mongodb-client-encryption";
+  npmPackage === "kerberos" || npmPackage === "mongodb-client-encryption";
 const template = readFileSync(
   join(__dirname, "./release_template.yml"),
   "utf-8",
@@ -25,13 +28,13 @@ const EVERGREEN_PROJECTS = {
 
 const generated = template
   .replaceAll("RELEASE_BRANCH", branch)
-  .replaceAll("RELEASE_PACKAGE", package)
+  .replaceAll("RELEASE_PACKAGE", npmPackage)
   .replaceAll("RELEASE_TAG", tag)
-  .replaceAll("EVERGREEN_PROJECT", EVERGREEN_PROJECTS[package] ?? "")
+  .replaceAll("EVERGREEN_PROJECT", EVERGREEN_PROJECTS[npmPackage] ?? "")
   .replaceAll("IGNORE_INSTALL_SCRIPTS", isNative)
   .replaceAll("SILK_ASSET_GROUP", assetGroup ?? "''");
 
-const project = EVERGREEN_PROJECTS[package];
+const project = EVERGREEN_PROJECTS[npmPackage];
 if (!project) {
   const final = generated
     .split("\n")

node/release_template.yml

@@ -59,15 +59,15 @@ jobs:
 
       - name: Copy sbom file to release assets
         shell: bash
-        if: ${{ SILK_ASSET_GROUP == '' }}
+        if: ${{ 'SILK_ASSET_GROUP' == '' }}
         run: cp sbom.json ${{ env.S3_ASSETS }}/sbom.json
 
       # only used for mongodb-client-encryption
       - name: Augment SBOM and copy to release assets
-        if: ${{ SILK_ASSET_GROUP != '' }}
+        if: ${{ 'SILK_ASSET_GROUP' != '' }}
         uses: mongodb-labs/drivers-github-tools/sbom@v2
         with:
-          silk_asset_group: ${{ SILK_ASSET_GROUP }}
+          silk_asset_group: SILK_ASSET_GROUP
           sbom_file_name: sbom.json
 
       - name: Generate authorized pub report

node/sign_node_package/action.yml

@@ -17,7 +17,7 @@ inputs:
   dry_run:
     description: "Should we upload files to the release?"
     required: false
-    default: "true"
+    default: "false"
   artifact_directory:
     description: The directory in which to output signatures.
     default: artifacts
@@ -50,7 +50,7 @@ runs:
         aws_role_arn: ${{ inputs.aws_role_arn }}
         aws_secret_id: ${{ inputs.aws_secret_id }}
 
-    - name: Determine what files to sign
+    - name: Determine what files to sign (native packages, works with glob patterns of build artifacts)
       if: ${{ inputs.sign_native == 'true' }}
       shell: bash
       run: |
@@ -61,7 +61,7 @@ runs:
         FILENAMES="$FILENAMES ${{ env.package_file }}"
         echo "FILES_TO_SIGN=${FILENAMES}" >> "$GITHUB_ENV"
 
-    - name: Determine what files to sign
+    - name: Determine what files to sign (non-native packages, with only the release tarball)
       if: ${{ inputs.sign_native != 'true' }}
       shell: bash
       run: |
@@ -77,11 +77,9 @@ runs:
 
     - name: Copy the tarballs to the artifacts directory
       shell: bash
-      run: for filename in ${{ env.FILES_TO_SIGN }}; do cp ${filename} artifacts/; done
-
-    - name: Display structure of downloaded files
-      shell: bash
-      run: ls -la artifacts/
+      run: |
+        for filename in ${{ env.FILES_TO_SIGN }}; do cp ${filename} artifacts/; done
+        ls -la artifacts/
 
     - name: "Upload release artifacts"
       if: ${{ inputs.dry_run == false }}