EC feedback

Author: norareidy

source/includes/monitoring/sdam.c

@@ -9,34 +9,35 @@ typedef struct {
 static void
 server_opening (const mongoc_apm_server_opening_t *event)
 {
-   stats_t *context;
-
-   context = (stats_t *) mongoc_apm_server_opening_get_context (event);
-   context->server_opening_events++;
+   stats_t *stats = (stats_t *) mongoc_apm_server_opening_get_context (event);
+   stats->server_opening_events += 1;
 
    printf ("Server opening: %s\n", mongoc_apm_server_opening_get_host (event)->host_and_port);
 }
 
 int
 main (void)
 {
-   mongoc_client_t *client;
-   mongoc_apm_callbacks_t *cbs
-   stats_t stats = {0};
    mongoc_init ();
 
-   client = mongoc_client_new ("<connection string URI>");
+   stats_t stats = {0};
 
-   cbs = mongoc_apm_callbacks_new ();
-   mongoc_apm_set_server_opening_cb (cbs, server_opening);
-   mongoc_client_set_apm_callbacks (client, cbs, (void *) &stats);
+   mongoc_client_t *client = mongoc_client_new ("<connection string URI>");
+   
+   {
+      mongoc_apm_callbacks_t *cbs = mongoc_apm_callbacks_new ();
+      mongoc_apm_set_server_opening_cb (cbs, server_opening);
+      mongoc_client_set_apm_callbacks (client, cbs, &stats);
+      mongoc_apm_callbacks_destroy (cbs);
+   }
 
    // Perform database operations
 
-   mongoc_client_destroy (client);
-   mongoc_apm_callbacks_destroy (cbs);
+   mongoc_client_destroy (client);   
+
+   printf ("Observed %d server opening events\n", stats.server_opening_events);
 
    mongoc_cleanup ();
 
    return EXIT_SUCCESS;
-}
+}

source/monitoring/cluster-monitoring.txt

@@ -36,22 +36,22 @@ Subscribe to Events
 -------------------
 
 You can access details about SDAM events by subscribing to them
-in your application. To subscribe to an event, create a value of
-type ``mongoc_apm_callbacks_t`` and create an event callback function
-for the event you want to subscribe to. Use the callback's corresponding
-setter method to set the callback on the ``mongoc_apm_callbacks_t`` and 
-pass this type to the ``mongoc_client_set_apm_callbacks()`` function.
+in your application. To subscribe to an event, define an Application
+Performance Monitoring (APM) callback function to handle each event
+type you want to subscribe to. Use a ``mongoc_apm_callbacks_t`` object
+to register the list of APM callbacks with a client using the
+``mongoc_client_set_apm_callbacks()`` function.
 
 This code monitors server opening events by performing the following
 actions:
 
-- Defines a ``server_opening()`` event handler function, or callback
-- Creates a ``mongoc_apm_callbacks_t`` structure to store callbacks
-- Calls the ``mongoc_apm_set_server_opening_cb()`` function, which instructs
-  the ``mongoc_apm_callbacks_t`` type to store a pointer to the ``server_opening()``
-  callback
+- Defines a ``server_opening()`` APM callback function
+- Creates a ``mongoc_apm_callbacks_t`` object to store callbacks
+- Calls the ``mongoc_apm_set_server_opening_cb()`` function, which
+  stores a pointer to the provided APM callback function in the
+  ``mongoc_apm_callbacks_t`` object
 - Calls the ``mongoc_client_set_apm_callbacks()`` function, which registers
-  the callback with the client
+  the callback in the ``mongoc_apm_callbacks_t`` object with the client
 
 .. literalinclude:: /includes/monitoring/sdam.c
    :language: c