Skip to content

Docsp 13857 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 10, 2021
Merged

Docsp 13857 #16

merged 14 commits into from
Aug 10, 2021

Conversation

terakilobyte
Copy link
Member

@terakilobyte terakilobyte commented Aug 4, 2021

Pull Request Info

This includes a few key changes along with implementing the page. It:

  • Uses constants defined in snooty.toml to help with versions in links.
  • Uses the proposed uri declaration leveraging environmental variables
  • Renames the update and replace section to "Write Operations"
  • Includes a go.mod and a go.sum file to enable running files in the code-snippets directly in place (no copy/paste from some other project).

Issue JIRA link:

https://jira.mongodb.org/browse/DOCSP-13857

Docs staging link (requires sign-in on MongoDB Corp SSO):

https://docs-mongodbcom-staging.corp.mongodb.com/golang/docsworker-xlarge/DOCSP-13857/usage-examples/insertOne/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Does it render on staging correctly?
  • Are all the links working?
    • The link to view the full example won't work until this PR is merged.
  • Are the staging links in the PR description updated?

Copy link
Contributor

@kyuan-mongodb kyuan-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some nits and suggestions!

@terakilobyte terakilobyte requested a review from kevinAlbs August 4, 2021 22:02
@terakilobyte
Copy link
Member Author

@kevinAlbs Ready for dbx review.

@kevinAlbs kevinAlbs requested review from matthewdale and removed request for kevinAlbs August 4, 2021 23:44
Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus a few suggestions!

Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@terakilobyte terakilobyte merged commit 91c1c33 into mongodb:master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants