Skip to content

Commit 61387d4

Browse files
committed
stincmale feedback
1 parent e715a15 commit 61387d4

File tree

2 files changed

+18
-15
lines changed

2 files changed

+18
-15
lines changed

source/upgrade.txt

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,6 @@ This driver version introduces the following breaking changes:
8787

8888
VectorSearchOptions opts = vectorSearchOptions().filter(eq("x", 8));
8989

90-
.. _java-breaking-changes-v5.0-observables:
91-
92-
.. After the 5.0 Scala API docs are released, this line will be uncommented.
93-
For more information, see the `Observable trait documentation <https://mongodb.github.io/mongo-java-driver/5.0/apidocs/mongo-scala-driver/org/mongodb/scala/Observable.html>`__.
94-
9590
- Removes the ``Parameterizable`` interface. Instead of
9691
implementing this interface on a custom ``Codec`` type,
9792
override the ``CodecProvider.get()`` method on the
@@ -108,11 +103,12 @@ This driver version introduces the following breaking changes:
108103
``$collStats`` aggregation pipeline stage. For an example of how to use this pipeline
109104
stage, see :manual:`What's New <java-deprecations-4.11>` for v4.11 of the {+driver-short+}.
110105

111-
- Removes the ``IterableCodec`` and ``MapCodec`` types.
112-
Use ``MapCodecProvider`` instead of ``MapCodec``, and ``CollectionCodecProvider``
113-
instead of ``IterableCodec``.
106+
- The ``MapCodec`` and ``IterableCodec`` classes are deprecated.
107+
Instead of ``MapCodec``, use ``MapCodecProvider``. Instead of ``IterableCodec``,
108+
use ``CollectionCodecProvider``, or ``IterableCodecProvider`` for ``Iterable``
109+
types that aren't ``Collection``s.
114110

115-
- Removes the ``sharded`` and ``nonAtomic`` options from the
111+
- Removes the ``sharded()`` and ``nonAtomic()`` methods from the
116112
``MapReducePublisher`` and ``MapReduceIterable`` classes.
117113

118114
- Removes the following methods for use with ``geoHaystack`` indexes:
@@ -146,7 +142,7 @@ This driver version introduces the following breaking changes:
146142

147143
- ``acknowledged(Type, int, List<BulkWriteUpsert>)``
148144
- ``acknowledged(Type, int, Integer, List<BulkWriteUpsert>)``
149-
- ``acknowledged(int, int, int, Integer, List<BulkWriteUpsert>)<String>)``
145+
- ``acknowledged(int, int, int, Integer, List<BulkWriteUpsert>)``
150146

151147
- Removes the following ``ChangeStreamDocument`` constructors:
152148

@@ -178,15 +174,21 @@ This driver version introduces the following breaking changes:
178174
- Removes the ``errorLabels`` option from the ``WriteConcernError``
179175
class. This includes the ``addLabel()`` and ``getErrorLabels()`` methods and the
180176
constructor that includes an ``errorLabels`` parameter. Instead, you can use
181-
the error labels included in the top-level response document.
177+
the error labels included in the ``MongoException`` object that contains the
178+
``WriteConcernError``.
179+
180+
.. _java-breaking-changes-v5.0-observables:
182181

183182
- Removes the
184183
``org.mongodb.scala.ObservableImplicits.ToSingleObservableVoid`` implicit
185184
class from the Scala driver package. This means the
186185
``org.reactivestreams.Publisher[Void]`` type no longer
187186
converts automatically to ``org.mongodb.scala.SingleObservable[Void]``. The
188187
API also exposes ``org.mongodb.scala.Observable[Unit]`` instead of
189-
``org.mongodb.scala.Observable[Void]``.
188+
``org.mongodb.scala.Observable[Void]``.
189+
190+
.. After the 5.0 Scala API docs are released, this line will be uncommented.
191+
For more information, see the `Observable trait documentation <https://mongodb.github.io/mongo-java-driver/5.0/apidocs/mongo-scala-driver/org/mongodb/scala/Observable.html>`__.
190192

191193
- Introduces the following changes to the ``ConnectionId`` class:
192194

source/whats-new.txt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -293,9 +293,10 @@ What's New in 4.8
293293

294294
.. important:: Deprecation Notice
295295

296-
The ``IterableCodec`` and ``MapCodec`` classes are deprecated.
297-
Use ``MapCodecProvider`` instead of ``MapCodec`` and ``CollectionCodecProvider``
298-
instead of ``IterableCodec``.
296+
The ``MapCodec`` and ``IterableCodec`` classes are deprecated.
297+
Instead of ``MapCodec``, use ``MapCodecProvider``. Instead of ``IterableCodec``,
298+
use ``CollectionCodecProvider``, or ``IterableCodecProvider`` for ``Iterable``
299+
types that aren't ``Collection``s.
299300

300301
Behavioral changes with the 4.8 driver release include:
301302

0 commit comments

Comments
 (0)