Skip to content

DOCSP-33345: Java comments pt. 6 #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

@norareidy norareidy marked this pull request as ready for review October 16, 2023 16:12
Copy link
Collaborator

@caitlindavey caitlindavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the one change has been made

cursor.forEach(doc -> System.out.println(doc));
}

private void uniqueIndex() {
System.out.println("unique index");
collection = database.getCollection("theaters");

// Creates a unique index on the "theaterID" field in descending order
// begin unique index
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this comment

Suggested change
// begin unique index
// begin unique index

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment should be kept since it is used for the literalinclude directive here.

In the Code Comment Style Guide, it's identified as a "Marker" comment type.

@norareidy norareidy merged commit 5762399 into mongodb:master Oct 27, 2023
@norareidy norareidy deleted the DOCSP-33345-java-comments-6 branch October 27, 2023 17:32
norareidy added a commit that referenced this pull request Oct 27, 2023
* DOCSP-33345: Java comments pt. 6

* edits

* more files

* duplicate comments spreadsheet suggestions

(cherry picked from commit 5762399)
norareidy added a commit that referenced this pull request Oct 27, 2023
* DOCSP-33345: Java comments pt. 6

* edits

* more files

* duplicate comments spreadsheet suggestions

(cherry picked from commit 5762399)
norareidy added a commit that referenced this pull request Oct 27, 2023
* DOCSP-33345: Java comments pt. 6

* edits

* more files

* duplicate comments spreadsheet suggestions

(cherry picked from commit 5762399)
norareidy added a commit that referenced this pull request Oct 27, 2023
* DOCSP-33345: Java comments pt. 6

* edits

* more files

* duplicate comments spreadsheet suggestions

(cherry picked from commit 5762399)
norareidy added a commit that referenced this pull request Oct 27, 2023
* DOCSP-33345: Java comments pt. 6

* edits

* more files

* duplicate comments spreadsheet suggestions

(cherry picked from commit 5762399)
norareidy added a commit that referenced this pull request Oct 27, 2023
* DOCSP-33345: Java comments pt. 6

* edits

* more files

* duplicate comments spreadsheet suggestions

(cherry picked from commit 5762399)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants