DOCSP-32718: Compound comments #771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustagir
approved these changes
Aug 31, 2023
| @@ -5,12 +5,16 @@ const { MongoClient } = require("mongodb"); | |||
| const uri = | |||
| "mongodb+srv://<user>:<password>@<cluster-url>?writeConcern=majority"; | |||
|
|
|||
| // Create a new instance of the MongoClient using the provided URI | |||
There was a problem hiding this comment.
S: Simplify
Suggested change
| // Create a new instance of the MongoClient using the provided URI | |
| // Create a new client and connect to MongoDB |
| const client = new MongoClient(uri); | ||
|
|
||
| // Define a function to interact with the MongoDB database |
There was a problem hiding this comment.
S: delete this code comment, as it is not related to the mongodb operation (it is JS scaffolding)
| const sort = { type: 1, genre: 1 }; | ||
| // Include the type and genre fields in the query results |
There was a problem hiding this comment.
Suggested change
| // Include the type and genre fields in the query results | |
| // Include only the type and genre fields in the query results |
| await client.close(); | ||
| } | ||
| } | ||
| // Call the "run" function and handle any errors using console.dir |
There was a problem hiding this comment.
Suggested change
| // Call the "run" function and handle any errors using console.dir | |
| // Run the function and handle any errors |
norareidy
added a commit
that referenced
this pull request
Sep 12, 2023
* DOCSP-32718: insertOne comments * DOCSP-32718: runCommand comments * DOCSP-32718: compound comments * Revert "DOCSP-32718: insertOne comments" This reverts commit 6d1c8ac. * Revert "DOCSP-32718: runCommand comments" This reverts commit d7a2f49. * addressing feedback (cherry picked from commit f751b1b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-32718
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/node/docsworker-xlarge/DOCSP-32718-compound-comments/fundamentals/indexes/
Self-Review Checklist