DOCSP-32548: Breaking changes consolidation #777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustagir
requested changes
Sep 5, 2023
Comment on lines
-88
to
-91
| - The ``includeResultMetadata`` option for compound operation methods | ||
| is ``false`` by default. See the :ref:`Built-in | ||
| Methods <node-compound-operations-builtin>` section of the Compound | ||
| Operations guide for more information. |
There was a problem hiding this comment.
S: for certain entries, a page is linked in this note, but not in the breaking changes guide. Could you go through and make sure that additional information is linked in the breaking changes guide wherever they have been linked in these admonitions?
There was a problem hiding this comment.
Thanks for catching this! I've added the links to installing the socks package (node-connect-socks) and information about compound operations (node-compound-operations-builtin).
norareidy
added a commit
that referenced
this pull request
Sep 8, 2023
* DOCSP-32548: Breaking changes consolidation * changing admonition * deleting repeated info * review feedback (cherry picked from commit 2e0cac9)
mongoKart
pushed a commit
to mongoKart/docs-node
that referenced
this pull request
Nov 3, 2023
* DOCSP-32548: Breaking changes consolidation * changing admonition * deleting repeated info * review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-32548
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/node/docsworker-xlarge/DOCSP-32548-consolidate-breaking/whats-new/
Self-Review Checklist