-
Notifications
You must be signed in to change notification settings - Fork 52
DOCSP-46471: Fix 404 link #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
source/faq.txt
Outdated
behavior, see the :manual:`Server version 4.2 release notes | ||
</release-notes/4.2/#client-disconnection>` in the Server manual. | ||
behavior, see the `Server version 4.2 release notes | ||
<https://www.mongodb.com/docs/v6.2/release-notes/4.2/#client-disconnection>`__. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't see anything in the RST to shorten this url a la :manual:
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am seeing that the link does not match the text. If 4.2 is what your target is, then you can use this role
https://github.com/mongodb/snooty-parser/blob/6dfe90640a833b11275f8cd37cbbf56ea8436d92/snooty/rstspec.toml#L1323-L1324
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 4.2 path doesn't appear to work anymore – 4.2 has been shifted to download-only legacy docs.
I could always just remove this link here since I imagine 6.2 will one day be sunset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see. I think the entry as it is provides enough info to justify removing the link altogether. You could also submit a PR to remove some of those roles from the rstspec, but thats out of scope, up to you but good for maintenance!
source/faq.txt
Outdated
behavior, see the :manual:`Server version 4.2 release notes | ||
</release-notes/4.2/#client-disconnection>` in the Server manual. | ||
behavior, see the `Server version 4.2 release notes | ||
<https://www.mongodb.com/docs/v6.2/release-notes/4.2/#client-disconnection>`__. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am seeing that the link does not match the text. If 4.2 is what your target is, then you can use this role
https://github.com/mongodb/snooty-parser/blob/6dfe90640a833b11275f8cd37cbbf56ea8436d92/snooty/rstspec.toml#L1323-L1324
source/faq.txt
Outdated
behavior, see the :manual:`Server version 4.2 release notes | ||
</release-notes/4.2/#client-disconnection>` in the Server manual. | ||
behavior, see the `Server version 4.2 release notes | ||
<https://www.mongodb.com/docs/v6.2/release-notes/4.2/#client-disconnection>`__. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see. I think the entry as it is provides enough info to justify removing the link altogether. You could also submit a PR to remove some of those roles from the rstspec, but thats out of scope, up to you but good for maintenance!
(cherry picked from commit 3e06b40)
(cherry picked from commit 3e06b40)
(cherry picked from commit 3e06b40)
(cherry picked from commit 3e06b40)
(cherry picked from commit 3e06b40)
(cherry picked from commit 3e06b40)
(cherry picked from commit 3e06b40)
(cherry picked from commit 3e06b40)
(cherry picked from commit 3e06b40)
(cherry picked from commit 3e06b40)
(cherry picked from commit 3e06b40)
(cherry picked from commit 3e06b40)
(cherry picked from commit 3e06b40)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-46471
Staging - https://deploy-preview-954--docs-node.netlify.app/faq/
Self-Review Checklist