Skip to content

DOCSP-46471: Fix 404 link #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Jan 14, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-46471
Staging - https://deploy-preview-954--docs-node.netlify.app/faq/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for docs-node ready!

Name Link
🔨 Latest commit 44046b7
🔍 Latest deploy log https://app.netlify.com/sites/docs-node/deploys/6786e1fa45a1850008213d09
😎 Deploy Preview https://deploy-preview-954--docs-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

source/faq.txt Outdated
behavior, see the :manual:`Server version 4.2 release notes
</release-notes/4.2/#client-disconnection>` in the Server manual.
behavior, see the `Server version 4.2 release notes
<https://www.mongodb.com/docs/v6.2/release-notes/4.2/#client-disconnection>`__.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't see anything in the RST to shorten this url a la :manual:.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am seeing that the link does not match the text. If 4.2 is what your target is, then you can use this role
https://github.com/mongodb/snooty-parser/blob/6dfe90640a833b11275f8cd37cbbf56ea8436d92/snooty/rstspec.toml#L1323-L1324

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 4.2 path doesn't appear to work anymore – 4.2 has been shifted to download-only legacy docs.

I could always just remove this link here since I imagine 6.2 will one day be sunset.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see. I think the entry as it is provides enough info to justify removing the link altogether. You could also submit a PR to remove some of those roles from the rstspec, but thats out of scope, up to you but good for maintenance!

source/faq.txt Outdated
behavior, see the :manual:`Server version 4.2 release notes
</release-notes/4.2/#client-disconnection>` in the Server manual.
behavior, see the `Server version 4.2 release notes
<https://www.mongodb.com/docs/v6.2/release-notes/4.2/#client-disconnection>`__.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am seeing that the link does not match the text. If 4.2 is what your target is, then you can use this role
https://github.com/mongodb/snooty-parser/blob/6dfe90640a833b11275f8cd37cbbf56ea8436d92/snooty/rstspec.toml#L1323-L1324

source/faq.txt Outdated
behavior, see the :manual:`Server version 4.2 release notes
</release-notes/4.2/#client-disconnection>` in the Server manual.
behavior, see the `Server version 4.2 release notes
<https://www.mongodb.com/docs/v6.2/release-notes/4.2/#client-disconnection>`__.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see. I think the entry as it is provides enough info to justify removing the link altogether. You could also submit a PR to remove some of those roles from the rstspec, but thats out of scope, up to you but good for maintenance!

@mcmorisi mcmorisi merged commit 3e06b40 into mongodb:master Jan 14, 2025
1 check passed
@mcmorisi mcmorisi deleted the DOCSP-46471-faq-link branch January 14, 2025 22:15
mcmorisi added a commit that referenced this pull request Jan 14, 2025
(cherry picked from commit 3e06b40)
mcmorisi added a commit that referenced this pull request Jan 14, 2025
(cherry picked from commit 3e06b40)
mcmorisi added a commit that referenced this pull request Jan 14, 2025
(cherry picked from commit 3e06b40)
mcmorisi added a commit that referenced this pull request Jan 14, 2025
(cherry picked from commit 3e06b40)
mcmorisi added a commit that referenced this pull request Jan 14, 2025
(cherry picked from commit 3e06b40)
mcmorisi added a commit that referenced this pull request Jan 14, 2025
(cherry picked from commit 3e06b40)
mcmorisi added a commit that referenced this pull request Jan 14, 2025
(cherry picked from commit 3e06b40)
mcmorisi added a commit that referenced this pull request Jan 14, 2025
(cherry picked from commit 3e06b40)
mcmorisi added a commit that referenced this pull request Jan 14, 2025
(cherry picked from commit 3e06b40)
mcmorisi added a commit that referenced this pull request Jan 14, 2025
(cherry picked from commit 3e06b40)
mcmorisi added a commit that referenced this pull request Jan 14, 2025
(cherry picked from commit 3e06b40)
mcmorisi added a commit that referenced this pull request Jan 14, 2025
(cherry picked from commit 3e06b40)
mcmorisi added a commit that referenced this pull request Jan 14, 2025
(cherry picked from commit 3e06b40)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants