deleted float parser and added special test cases for Double

Author: aditi-khare-mongoDB

src/float_parser.ts

@@ -9,7 +9,6 @@ import type { Double } from '../double';
 import { ensureBuffer } from '../ensure_buffer';
 import { BSONError, BSONTypeError } from '../error';
 import { isBSONType } from '../extended_json';
-import { writeIEEE754 } from '../float_parser';
 import type { Int32 } from '../int_32';
 import { Long } from '../long';
 import { Map } from '../map';
@@ -119,7 +118,7 @@ function serializeNumber(
     index = index + numberOfWrittenBytes;
     buffer[index++] = 0;
     // Write float
-    writeIEEE754(buffer, value, index, 'little', 52, 8);
+    buffer.writeDoubleLE(value, index);
     // Adjust index
     index = index + 8;
   }
@@ -487,7 +486,7 @@ function serializeDouble(
   buffer[index++] = 0;
 
   // Write float
-  writeIEEE754(buffer, value.value, index, 'little', 52, 8);
+  buffer.writeDoubleLE(value.value, index); // little endian by default
 
   // Adjust index
   index = index + 8;

src/parser/serializer.ts

@@ -121,11 +121,6 @@ describe('BSON Corpus', function () {
         describe('valid-bson', function () {
           for (const v of valid) {
             it(v.description, function () {
-              if (v.description === 'NaN with payload') {
-                // TODO(NODE-3630): remove custom float parser so we can handle the NaN payload data
-                this.skip();
-              }
-
               if (
                 v.description === 'All BSON types' &&
                 scenario._filename === 'multi-type-deprecated'

test/node/bson_corpus.spec.test.js

@@ -35,4 +35,63 @@ describe('Double', function () {
       });
     }
   });
+
+  describe('specialValues', () => {
+    function twiceSerialized(value) {
+      let serializedDouble = BSON.serialize({ d: new Double(value) });
+      let deserializedDouble = BSON.deserialize(serializedDouble, { promoteValues: true });
+      let newVal = deserializedDouble.d;
+      return newVal;
+    }
+
+    it('inf', () => {
+      let value = Infinity;
+      let orig = new Double(value).valueOf();
+      let newVal = twiceSerialized(value);
+      expect(orig).to.equal(newVal);
+    });
+
+    it('-inf', () => {
+      let value = -Infinity;
+      let orig = new Double(value).valueOf();
+      let newVal = twiceSerialized(value);
+      expect(orig).to.equal(newVal);
+    });
+
+    it('NaN', () => {
+      let value = NaN;
+      let newVal = twiceSerialized(value);
+      expect(Number.isNaN(newVal)).to.equal(true);
+    });
+
+    it('NaN with payload', () => {
+      let buffer = Buffer.from('120000000000F87F', 'hex');
+      let value = buffer.readDoubleLE(0);
+      let serializedDouble = BSON.serialize({ d: new Double(value) });
+      expect(serializedDouble.subarray(7, 15)).to.deep.equal(buffer);
+      let { d: newVal } = BSON.deserialize(serializedDouble, { promoteValues: true });
+      expect(Number.isNaN(newVal)).to.equal(true);
+    });
+
+    it('0', () => {
+      let value = 0;
+      let orig = new Double(value).valueOf();
+      let newVal = twiceSerialized(value);
+      expect(orig).to.equal(newVal);
+    });
+
+    it('-0', () => {
+      let value = -0;
+      let orig = new Double(value).valueOf();
+      let newVal = twiceSerialized(value);
+      expect(orig).to.equal(newVal);
+    });
+
+    it('Number.EPSILON', () => {
+      let value = Number.EPSILON;
+      let orig = new Double(value).valueOf();
+      let newVal = twiceSerialized(value);
+      expect(orig).to.equal(newVal);
+    });
+  });
 });