ci(NODE-5087): download node to local directory (#566)

nbbeeken · web-flow · commit 24c6a9c25214 · 2023-03-16T16:45:37.000+01:00
diff --git a/.evergreen/config.yml b/.evergreen/config.yml
@@ -29,32 +29,35 @@ functions:
     - command: expansions.update
       params:
         file: src/expansion.yml
+
   install dependencies:
-    - command: shell.exec
+    - command: subprocess.exec
       type: setup
       params:
         working_dir: src
-        script: |
-          ${PREPARE_SHELL}
-          echo "NODE_VERSION=${NODE_VERSION}"
-          NODE_VERSION=${NODE_VERSION} ${PROJECT_DIRECTORY}/.evergreen/install-dependencies.sh
+        binary: bash
+        add_expansions_to_env: true
+        args:
+          - .evergreen/install-dependencies.sh
+
   run tests:
     - command: shell.exec
       type: test
       params:
         working_dir: src
         script: |
           ${PREPARE_SHELL}
-          echo "NODE_VERSION=${NODE_VERSION} NO_BIGINT=${NO_BIGINT} TEST_TARGET=${TEST_TARGET}"
-          NODE_VERSION=${NODE_VERSION} NO_BIGINT=${NO_BIGINT} ${PROJECT_DIRECTORY}/.evergreen/run-tests.sh ${TEST_TARGET}
+          echo "NO_BIGINT=${NO_BIGINT} TEST_TARGET=${TEST_TARGET}"
+          NO_BIGINT=${NO_BIGINT} ${PROJECT_DIRECTORY}/.evergreen/run-tests.sh ${TEST_TARGET}
+
   run checks:
     - command: shell.exec
       type: test
       params:
         working_dir: src
         script: |
           ${PREPARE_SHELL}
-          echo "NODE_VERSION=${NODE_VERSION} TEST_TARGET=${TEST_TARGET}"
+          echo "TEST_TARGET=${TEST_TARGET}"
           bash ${PROJECT_DIRECTORY}/.evergreen/run-checks.sh
   run typescript:
     - command: subprocess.exec
@@ -76,7 +79,6 @@ functions:
         working_dir: src
         timeout_secs: 60
         env:
-          NODE_VERSION: ${NODE_VERSION}
           PROJECT_DIRECTORY: ${PROJECT_DIRECTORY}
         binary: bash
         args:
@@ -88,7 +90,6 @@ functions:
         working_dir: src
         binary: bash
         env:
-          NODE_VERSION: ${NODE_VERSION}
           PROJECT_DIRECTORY: ${PROJECT_DIRECTORY}
         args:
           - .evergreen/run-bundling-test.sh
@@ -99,7 +100,7 @@ tasks:
     commands:
       - func: fetch source
         vars:
-          NODE_MAJOR_VERSION: 14
+          NODE_LTS_NAME: fermium
       - func: install dependencies
       - func: run tests
         vars:
@@ -109,7 +110,7 @@ tasks:
     commands:
       - func: fetch source
         vars:
-          NODE_MAJOR_VERSION: 16
+          NODE_LTS_NAME: gallium
       - func: install dependencies
       - func: run tests
         vars:
@@ -119,7 +120,7 @@ tasks:
     commands:
       - func: fetch source
         vars:
-          NODE_MAJOR_VERSION: 18
+          NODE_LTS_NAME: hydrogen
       - func: install dependencies
       - func: run tests
         vars:
@@ -129,7 +130,7 @@ tasks:
     commands:
       - func: fetch source
         vars:
-          NODE_MAJOR_VERSION: latest
+          NODE_LTS_NAME: latest
       - func: install dependencies
       - func: run tests
         vars:
@@ -139,7 +140,7 @@ tasks:
     commands:
       - func: fetch source
         vars:
-          NODE_MAJOR_VERSION: 18
+          NODE_LTS_NAME: hydrogen
       - func: install dependencies
       - func: run tests
         vars:
@@ -148,15 +149,15 @@ tasks:
     commands:
       - func: fetch source
         vars:
-          NODE_MAJOR_VERSION: 18
+          NODE_LTS_NAME: hydrogen
       - func: install dependencies
       - func: run bundling
   - name: no-bigint-web-tests
     tags: ["no-bigint", "web"]
     commands:
       - func: fetch source
         vars:
-          NODE_MAJOR_VERSION: 18
+          NODE_LTS_NAME: hydrogen
       - func: install dependencies
       - func: run tests
         vars:
@@ -168,14 +169,14 @@ tasks:
     commands:
       - func: fetch source
         vars:
-          NODE_MAJOR_VERSION: 18
+          NODE_LTS_NAME: hydrogen
       - func: install dependencies
       - func: run checks
   - name: check-typescript-oldest
     commands:
       - func: fetch source
         vars:
-          NODE_MAJOR_VERSION: 18
+          NODE_LTS_NAME: hydrogen
       - func: install dependencies
       - func: "run typescript"
         vars:
@@ -185,7 +186,7 @@ tasks:
     commands:
       - func: fetch source
         vars:
-          NODE_MAJOR_VERSION: 18
+          NODE_LTS_NAME: hydrogen
       - func: install dependencies
       - func: "run typescript"
         vars:
@@ -195,7 +196,7 @@ tasks:
     commands:
       - func: fetch source
         vars:
-          NODE_MAJOR_VERSION: 18
+          NODE_LTS_NAME: hydrogen
       - func: install dependencies
       - func: "run typescript"
         vars:
@@ -205,7 +206,7 @@ tasks:
     commands:
       - func: fetch source
         vars:
-          NODE_MAJOR_VERSION: 18
+          NODE_LTS_NAME: hydrogen
       - func: install dependencies
       - func: run eslint plugin tests
 
diff --git a/.evergreen/init-nvm.sh b/.evergreen/init-nvm.sh
@@ -1,9 +1,13 @@
 #! /usr/bin/env bash
 
 export PATH="/opt/mongodbtoolchain/v2/bin:$PATH"
+
 NODE_ARTIFACTS_PATH="${PROJECT_DIRECTORY}/node-artifacts"
-export NVM_DIR="${NODE_ARTIFACTS_PATH}/nvm"
+if [[ "$OS" == "Windows_NT" ]]; then
+  NODE_ARTIFACTS_PATH=$(cygpath --unix "$NODE_ARTIFACTS_PATH")
+fi
 
-[ -s "$NVM_DIR/nvm.sh" ] && source "$NVM_DIR/nvm.sh"
+export PATH="$NODE_ARTIFACTS_PATH/npm_global/bin:$NODE_ARTIFACTS_PATH/nodejs/bin:$PATH"
+hash -r
 
 export NODE_OPTIONS="--trace-deprecation --trace-warnings"
diff --git a/.evergreen/install-dependencies.sh b/.evergreen/install-dependencies.sh
@@ -1,53 +1,108 @@
-#!/bin/bash
-if [ -z "$NODE_VERSION" ]; then
-  echo "NODE_VERSION environment variable must be specified"
+#!/usr/bin/env bash
+set -o errexit  # Exit the script with error if any of the commands fail
+
+NODE_LTS_NAME=${NODE_LTS_NAME:-fermium}
+NODE_ARTIFACTS_PATH="${PROJECT_DIRECTORY:-$(pwd)}/node-artifacts"
+if [[ "$OS" = "Windows_NT" ]]; then NODE_ARTIFACTS_PATH=$(cygpath --unix "$NODE_ARTIFACTS_PATH"); fi
+
+CURL_FLAGS=(
+  --fail          # Exit code 1 if request fails
+  --compressed    # Request a compressed response should keep fetching fast
+  --location      # Follow a redirect
+  --retry 8       # Retry HTTP 408, 429, 500, 502, 503 or 504, 8 times
+  --silent        # Do not print a progress bar
+  --show-error    # Despite the silent flag still print out errors
+  --max-time 900  # 900 seconds is 15 minutes, evergreen times out at 20
+  --continue-at - # If a download is interrupted it can figure out where to resume
+)
+
+mkdir -p "$NODE_ARTIFACTS_PATH/npm_global"
+
+# Comparisons are all case insensitive
+shopt -s nocasematch
+
+# index.tab is a sorted tab separated values file with the following headers
+# 0       1    2     3   4  5  6    7       8       9   10
+# version date files npm v8 uv zlib openssl modules lts security
+curl "${CURL_FLAGS[@]}" "https://nodejs.org/dist/index.tab" --output node_index.tab
+
+while IFS=$'\t' read -r -a row; do
+  node_index_version="${row[0]}"
+  node_index_date="${row[1]}"
+  node_index_lts="${row[9]}"
+  [[ "$node_index_version" = "version" ]] && continue # skip tsv header
+  [[ "$NODE_LTS_NAME" = "latest" ]] && break # first line is latest
+  [[ "$NODE_LTS_NAME" = "$node_index_lts" ]] && break # case insensitive compare
+done < node_index.tab
+
+if [[ "$OS" = "Windows_NT" ]]; then
+  operating_system="win"
+elif [[ $(uname) = "darwin" ]]; then
+  operating_system="darwin"
+elif [[ $(uname) = "linux" ]]; then
+  operating_system="linux"
+else
+  echo "Unable to determine operating system: $operating_system"
   exit 1
 fi
 
-set -o errexit  # Exit the script with error if any of the commands fail
+architecture=$(uname -m)
+if [[ $architecture = "x86_64" ]]; then
+  architecture="x64"
+elif [[ $architecture = "arm64" ]]; then
+  architecture="arm64"
+elif [[ $architecture = "aarch64" ]]; then
+  architecture="arm64"
+elif [[ $architecture == s390* ]]; then
+  architecture="s390x"
+elif [[ $architecture == ppc* ]]; then
+  architecture="ppc64le"
+else
+  echo "Unable to determine operating system: $architecture"
+  exit 1
+fi
 
-NODE_ARTIFACTS_PATH="${PROJECT_DIRECTORY}/node-artifacts"
-NPM_CACHE_DIR="${NODE_ARTIFACTS_PATH}/npm"
-NPM_TMP_DIR="${NODE_ARTIFACTS_PATH}/tmp"
-BIN_DIR="$(pwd)/bin"
-NVM_URL="https://raw.githubusercontent.com/creationix/nvm/v0.38.0/install.sh"
+file_extension="tar.gz"
+if [[ "$OS" = "Windows_NT" ]]; then file_extension="zip"; fi
 
-# this needs to be explicitly exported for the nvm install below
-export NVM_DIR="${NODE_ARTIFACTS_PATH}/nvm"
+node_directory="node-${node_index_version}-${operating_system}-${architecture}"
+node_archive="${node_directory}.${file_extension}"
+node_archive_path="$NODE_ARTIFACTS_PATH/${node_archive}"
+node_download_url="https://nodejs.org/dist/${node_index_version}/${node_archive}"
 
-# create node artifacts path if needed
-mkdir -p "${NODE_ARTIFACTS_PATH}"
-mkdir -p "${NPM_CACHE_DIR}"
-mkdir -p "${NPM_TMP_DIR}"
-mkdir -p "${BIN_DIR}"
-mkdir -p "${NVM_DIR}"
+echo "Node.js ${node_index_version} for ${operating_system}-${architecture} released on ${node_index_date}"
 
-# Add mongodb toolchain to path
-export PATH="${BIN_DIR}:${PATH}"
+set -o xtrace
 
-# install Node.js
-echo "Installing Node ${NODE_LTS_NAME}"
+curl "${CURL_FLAGS[@]}" "${node_download_url}" --output "$node_archive_path"
 
-set +o xtrace
+if [[ "$file_extension" = "zip" ]]; then
+  unzip -q "$node_archive_path" -d "${NODE_ARTIFACTS_PATH}"
+  mkdir -p "${NODE_ARTIFACTS_PATH}/nodejs"
+  # Windows "bins" are at the top level
+  mv "${NODE_ARTIFACTS_PATH}/${node_directory}" "${NODE_ARTIFACTS_PATH}/nodejs/bin"
+  # Need to add executable flag ourselves
+  chmod +x "${NODE_ARTIFACTS_PATH}/nodejs/bin/node.exe"
+  chmod +x "${NODE_ARTIFACTS_PATH}/nodejs/bin/npm"
+else
+  tar -xf "$node_archive_path" -C "${NODE_ARTIFACTS_PATH}"
+  mv "${NODE_ARTIFACTS_PATH}/${node_directory}" "${NODE_ARTIFACTS_PATH}/nodejs"
+fi
 
-echo "  Downloading nvm"
-curl -o- $NVM_URL | bash
-[ -s "${NVM_DIR}/nvm.sh" ] && \. "${NVM_DIR}/nvm.sh"
+export PATH="$NODE_ARTIFACTS_PATH/npm_global/bin:$NODE_ARTIFACTS_PATH/nodejs/bin:$PATH"
+hash -r
 
-echo "Running: nvm install --lts --latest-npm"
-nvm install --lts --latest-npm
-echo "Running: nvm install ${NODE_VERSION}"
-nvm install "${NODE_VERSION}"
-echo "Running: nvm use --lts"
-nvm use --lts
+# Set npm -g prefix to our local artifacts directory
+cat <<EOT > .npmrc
+prefix=$NODE_ARTIFACTS_PATH/npm_global
+EOT
 
-set -o xtrace
+if [[ $operating_system != "win" ]]; then
+  # Update npm to latest when we can
+  npm install --global npm@latest
+  hash -r
+fi
 
-# install node dependencies
-npm install
+echo "npm version: $(npm -v)"
 
-set +o xtrace
-echo "Running: nvm use ${NODE_VERSION}"
-nvm use "${NODE_VERSION}" # Switch to the node version we want to test against
-echo "Success: switched to node $(node -v)"
-set -o xtrace
+npm install "${NPM_OPTIONS}"
diff --git a/.evergreen/run-checks.sh b/.evergreen/run-checks.sh
@@ -1,9 +1,6 @@
 #!/bin/bash
 set -o errexit  # Exit the script with error if any of the commands fail
 
-export PROJECT_DIRECTORY="$(pwd)"
-NODE_ARTIFACTS_PATH="${PROJECT_DIRECTORY}/node-artifacts"
-export NVM_DIR="${NODE_ARTIFACTS_PATH}/nvm"
-[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
+source "${PROJECT_DIRECTORY}/.evergreen/init-nvm.sh"
 
 npm run check:lint
diff --git a/.evergreen/run-eslint-plugin-test.sh b/.evergreen/run-eslint-plugin-test.sh
@@ -1,15 +1,8 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
-if [ -z "$NODE_VERSION" ]; then
-  echo "NODE_VERSION environment variable must be specified"
-  exit 1
-fi
+set -o errexit
 
-NODE_ARTIFACTS_PATH="${PROJECT_DIRECTORY}/node-artifacts"
-
-export PATH="/opt/mongodbtoolchain/v2/bin:$PATH"
-export NVM_DIR="${NODE_ARTIFACTS_PATH}/nvm"
-[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
+source "${PROJECT_DIRECTORY}/.evergreen/init-nvm.sh"
 
 cd etc/eslint/no-bigint-usage
 npm install
diff --git a/.evergreen/run-tests.sh b/.evergreen/run-tests.sh
@@ -1,15 +1,6 @@
-#!/bin/bash
-if [ -z "$NODE_VERSION" ]; then
-  echo "NODE_VERSION environment variable must be specified"
-  exit 1
-fi
-
-NODE_ARTIFACTS_PATH="${PROJECT_DIRECTORY}/node-artifacts"
-
-export PATH="/opt/mongodbtoolchain/v2/bin:$PATH"
-export NVM_DIR="${NODE_ARTIFACTS_PATH}/nvm"
-[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
+#!/usr/bin/env bash
 
+source "${PROJECT_DIRECTORY}/.evergreen/init-nvm.sh"
 
 case $1 in
   "node")
diff --git a/.evergreen/setup-environment.sh b/.evergreen/setup-environment.sh
diff --git a/test/register-bson.js b/test/register-bson.js
