#204 remove Buffer.from as it's partially broken in early 4.x.x. series of node releases

Author: christkv

lib/bson/objectid.js

@@ -49,7 +49,7 @@ var ObjectID = function ObjectID(id) {
   if(!valid && id != null){
     throw new Error("Argument passed in must be a single String of 12 bytes or a string of 24 hex characters");
   } else if(valid && typeof id == 'string' && id.length == 24 && hasBufferType) {
-    return new ObjectID(Buffer.from(id, 'hex'));
+    return new ObjectID(new Buffer(id, 'hex'));
   } else if(valid && typeof id == 'string' && id.length == 24) {
     return ObjectID.createFromHexString(id);
   } else if(id != null && id.length === 12) {
@@ -290,7 +290,7 @@ ObjectID.createFromHexString = function createFromHexString (string) {
   }
 
   // Use Buffer.from method if available
-  if(hasBufferType) return new ObjectID(Buffer.from(string, 'hex'));
+  if(hasBufferType) return new ObjectID(new Buffer(string, 'hex'));
 
   // Calculate lengths
   var array = new _Buffer(12);

test/node/object_id_tests.js

@@ -44,12 +44,12 @@ exports['should correctly create ObjectId from uppercase hexstring'] = function(
 exports['should correctly create ObjectId from Buffer'] = function(test) {
   if(!Buffer.from) return test.done();
   var a = 'AAAAAAAAAAAAAAAAAAAAAAAA';
-  var b = new ObjectId(Buffer.from(a, 'hex'));
+  var b = new ObjectId(new Buffer(a, 'hex'));
   var c = b.equals(a); // => false
   test.equal(true, c);
 
   var a = 'aaaaaaaaaaaaaaaaaaaaaaaa';
-  var b = new ObjectId(Buffer.from(a, 'hex'));
+  var b = new ObjectId(new Buffer(a, 'hex'));
   var c = b.equals(a); // => true
   test.equal(a, b.toString());
   test.equal(true, c);