#201 fix for inspect passing in non string parameter to toString

Author: christkv

lib/bson/objectid.js

@@ -171,7 +171,7 @@ ObjectID.prototype.generate = function(time) {
 ObjectID.prototype.toString = function(format) {
   // Is the id a buffer then use the buffer toString method to return the format
   if(this.id && this.id.copy) {
-    return this.id.toString(format || 'hex');
+    return this.id.toString(typeof format === 'string' ? format : 'hex');
   }
 
   // if(this.buffer )

test/node/object_id_tests.js

@@ -1,4 +1,5 @@
 var BSON = require('../..');
+var util = require('util');
 var ObjectId = BSON.ObjectID;
 
 /**
@@ -54,3 +55,23 @@ exports['should correctly create ObjectId from Buffer'] = function(test) {
   test.equal(true, c);
   test.done();
 }
+
+/**
+ * @ignore
+ */
+exports['should correctly allow for node.js inspect to work with ObjectId'] = function(test) {
+  var a = 'AAAAAAAAAAAAAAAAAAAAAAAA';
+  var b = new ObjectId(a);
+  util.inspect(b);
+
+  // var c = b.equals(a); // => false
+  // test.equal(true, c);
+  //
+  // var a = 'aaaaaaaaaaaaaaaaaaaaaaaa';
+  // var b = new ObjectId(a);
+  // var c = b.equals(a); // => true
+  // test.equal(true, c);
+  // test.equal(a, b.toString());
+
+  test.done();
+}