add upload to s3 capability

Author: baileympearson

.github/actions/publish_asset_to_s3/action.yml

@@ -14,8 +14,7 @@ inputs:
   dry_run:
     description: "Whether this is a dry run"
     required: false
-    type:  boolean
-    default: false
+    default: 'false'
 
 runs:
   using: composite
@@ -31,6 +30,7 @@ runs:
         else
             echo "Dry run, not uploading to S3 or creating GitHub Release"
             echo "Would upload $FILES"
+            cat $FILES
         fi
       env:
         VERSION: ${{ inputs.version }}

.github/workflows/release.yml

@@ -41,6 +41,7 @@ jobs:
   generate_sarif_report:
     environment: release
     runs-on: ubuntu-latest
+    needs: [release_please]
     permissions:
       # required for all workflows
       security-events: write
@@ -63,21 +64,11 @@ jobs:
         with:
           ref: main
           output-file: sarif-report.json
-    
-      - name: "Move sarif report to output file"
-        shell: bash
-        run: cp sarif-report.json ${{ env.S3_ASSETS }}/sarif-report.json
-
-      - name: 'Print (TODO - upload to s3 instead)'
-        shell: bash
-        run: |
-          ls ${{ env.S3_ASSETS }}
-          cat ${{ env.S3_ASSETS }}/sarif-report.json
 
       - name: actions/publish_asset_to_s3
         uses: ./.github/actions/publish_asset_to_s3
         with:
           version: v6.5.0
           product_name: js-bson-development
           files: sarif-report.json
-          dry_run: true
+          dry_run:  ${{ needs.release_please.outputs.release_created }}