update isValid return logic for strings

syz99 · syz99 · commit f8dbd4764952 · 2021-12-01T15:00:27.000-05:00
diff --git a/src/objectid.ts b/src/objectid.ts
@@ -301,9 +301,8 @@ export class ObjectId {
       if (id.length === 12) {
         const bytes = Buffer.from(id);
         return bytes.byteLength === 12;
-      } else if (id.length === 24) {
-        return checkForHexRegExp.test(id);
       }
+      return id.length === 24 && checkForHexRegExp.test(id);
     }
 
     if (id instanceof ObjectId) {

Original file line number	Diff line number	Diff line change
`@@ -301,9 +301,8 @@ export class ObjectId {`
`301`	`301`	`if (id.length === 12) {`
`302`	`302`	`const bytes = Buffer.from(id);`
`303`	`303`	`return bytes.byteLength === 12;`
`304`		`- } else if (id.length === 24) {`
`305`		`- return checkForHexRegExp.test(id);`
`306`	`304`	`}`
	`305`	`+ return id.length === 24 && checkForHexRegExp.test(id);`
`307`	`306`	`}`
`308`	`307`
`309`	`308`	`if (id instanceof ObjectId) {`