Skip to content

chore: add 5.x release workflow #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2023
Merged

chore: add 5.x release workflow #623

merged 1 commit into from
Sep 12, 2023

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

  • Adds release automation for 5.x branch
  • add benchmarks.json to gitignore
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Release automation for 5.x

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken requested a review from W-A-James September 12, 2023 15:17
@W-A-James W-A-James self-assigned this Sep 12, 2023
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 12, 2023
Copy link
Contributor

@W-A-James W-A-James left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@W-A-James W-A-James merged commit ce69cb6 into main Sep 12, 2023
@W-A-James W-A-James deleted the chore-5x-release branch September 12, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants