#1930 removed duplicate assignments

Treggats · Treggats · commit a0f4d4d1ace5 · 2023-11-03T21:42:23.000+01:00
diff --git a/src/Relations/EmbedsOneOrMany.php b/src/Relations/EmbedsOneOrMany.php
@@ -45,8 +45,6 @@ public function __construct(Builder $query, Model $parent, Model $related, strin
     {
         parent::__construct($query, $parent);
 
-        $this->query      = $query;
-        $this->parent     = $parent;
         $this->related    = $related;
         $this->localKey   = $localKey;
         $this->foreignKey = $foreignKey;
@@ -57,8 +55,6 @@ public function __construct(Builder $query, Model $parent, Model $related, strin
         if ($parentRelation) {
             $this->query = $parentRelation->getQuery();
         }
-
-        $this->addConstraints();
     }
 
     /** @inheritdoc */

Original file line number	Diff line number	Diff line change
`@@ -45,8 +45,6 @@ public function __construct(Builder $query, Model $parent, Model $related, strin`
`45`	`45`	`{`
`46`	`46`	`parent::__construct($query, $parent);`
`47`	`47`
`48`		`- $this->query = $query;`
`49`		`- $this->parent = $parent;`
`50`	`48`	`$this->related = $related;`
`51`	`49`	`$this->localKey = $localKey;`
`52`	`50`	`$this->foreignKey = $foreignKey;`
`@@ -57,8 +55,6 @@ public function __construct(Builder $query, Model $parent, Model $related, strin`
`57`	`55`	`if ($parentRelation) {`
`58`	`56`	`$this->query = $parentRelation->getQuery();`
`59`	`57`	`}`
`60`		`-`
`61`		`- $this->addConstraints();`
`62`	`58`	`}`
`63`	`59`
`64`	`60`	`/** @inheritdoc */`