Factorize integration tests

Author: GromNaN

tests/Scout/ScoutIntegrationTest.php

@@ -2,62 +2,73 @@
 
 namespace MongoDB\Laravel\Tests\Scout;
 
+use Illuminate\Database\Eloquent\Factories\Sequence;
+use Illuminate\Support\LazyCollection;
 use MongoDB\Laravel\Tests\Models\SqlUser;
 use MongoDB\Laravel\Tests\TestCase;
+use Orchestra\Testbench\Factories\UserFactory;
 
-use function class_exists;
 use function Orchestra\Testbench\artisan;
+use function range;
 use function sleep;
 
 class ScoutIntegrationTest extends TestCase
 {
-    use SearchableTests {
-        defineScoutDatabaseMigrations as baseDefineScoutDatabaseMigrations;
-    }
+    protected static string $userModel = SqlUser::class;
 
     protected function defineEnvironment($app)
     {
-        $this->defineScoutEnvironment($app);
+        $app['config']->set('scout.driver', 'mongodb');
+        $app['config']->set('scout.prefix', 'scout_');
     }
 
-    /**
-     * Define database migrations.
-     *
-     * @return void
-     */
-    protected function defineDatabaseMigrations()
+    protected function defineDatabaseMigrations(): void
     {
-        $this->defineScoutDatabaseMigrations();
-    }
+        SqlUser::executeSchema();
 
-    protected function defineScoutDatabaseMigrations()
-    {
-        $this->baseDefineScoutDatabaseMigrations();
+        $collect = LazyCollection::make(function () {
+            yield ['name' => 'Laravel Framework'];
 
-        $this->importScoutIndexFrom(SqlUser::class);
-    }
+            foreach (range(2, 10) as $key) {
+                yield ['name' => 'Example ' . $key];
+            }
 
-    protected function importScoutIndexFrom($model = null)
-    {
-        if (class_exists($model)) {
-            self::assertSame(0, artisan($this, 'scout:index', ['name' => $model]));
-        }
+            yield ['name' => 'Larry Casper', 'email_verified_at' => null];
+            yield ['name' => 'Reta Larkin'];
 
-        self::assertSame(0, artisan($this, 'scout:import', ['model' => $model]));
+            foreach (range(13, 19) as $key) {
+                yield ['name' => 'Example ' . $key];
+            }
 
-        sleep(1);
-    }
+            yield ['name' => 'Prof. Larry Prosacco DVM', 'email_verified_at' => null];
+
+            foreach (range(21, 38) as $key) {
+                yield ['name' => 'Example ' . $key, 'email_verified_at' => null];
+            }
+
+            yield ['name' => 'Linkwood Larkin', 'email_verified_at' => null];
+            yield ['name' => 'Otis Larson MD'];
+            yield ['name' => 'Gudrun Larkin'];
+            yield ['name' => 'Dax Larkin'];
+            yield ['name' => 'Dana Larson Sr.'];
+            yield ['name' => 'Amos Larson Sr.'];
+        });
+
+        UserFactory::new()
+            ->times(44)
+            ->state(new Sequence(...$collect->all()))
+            ->create();
 
-    protected function tearDown(): void
-    {
         self::assertSame(0, artisan($this, 'scout:delete-index', ['name' => SqlUser::class]));
+        self::assertSame(0, artisan($this, 'scout:index', ['name' => SqlUser::class]));
+        self::assertSame(0, artisan($this, 'scout:import', ['model' => SqlUser::class]));
 
-        parent::tearDown();
+        sleep(5);
     }
 
     public function testItCanUseBasicSearch()
     {
-        $results = $this->itCanUseBasicSearch();
+        $results = SqlUser::search('lar')->take(10)->get();
 
         $this->assertSame([
             11 => 'Larry Casper',
@@ -70,7 +81,9 @@ public function testItCanUseBasicSearch()
 
     public function testItCanUseBasicSearchWithQueryCallback()
     {
-        $results = $this->itCanUseBasicSearchWithQueryCallback();
+        $results = SqlUser::search('lar')->take(10)->query(function ($query) {
+            return $query->whereNotNull('email_verified_at');
+        })->get();
 
         $this->assertSame([
             42 => 'Dax Larkin',
@@ -81,7 +94,7 @@ public function testItCanUseBasicSearchWithQueryCallback()
 
     public function testItCanUseBasicSearchToFetchKeys()
     {
-        $results = $this->itCanUseBasicSearchToFetchKeys();
+        $results = SqlUser::search('lar')->take(10)->keys();
 
         $this->assertSame([
             11,
@@ -94,7 +107,9 @@ public function testItCanUseBasicSearchToFetchKeys()
 
     public function testItCanUseBasicSearchWithQueryCallbackToFetchKeys()
     {
-        $results = $this->itCanUseBasicSearchWithQueryCallbackToFetchKeys();
+        $results = SqlUser::search('lar')->take(10)->query(function ($query) {
+            return $query->whereNotNull('email_verified_at');
+        })->keys();
 
         $this->assertSame([
             11,
@@ -105,17 +120,10 @@ public function testItCanUseBasicSearchWithQueryCallbackToFetchKeys()
         ], $results->all());
     }
 
-    public function testItReturnSameKeysWithQueryCallback()
-    {
-        $this->assertSame(
-            $this->itCanUseBasicSearchToFetchKeys()->all(),
-            $this->itCanUseBasicSearchWithQueryCallbackToFetchKeys()->all(),
-        );
-    }
-
     public function testItCanUsePaginatedSearch()
     {
-        [$page1, $page2] = $this->itCanUsePaginatedSearch();
+        $page1 = SqlUser::search('lar')->take(10)->paginate(3, 'page', 1);
+        $page2 = SqlUser::search('lar')->take(10)->paginate(3, 'page', 2);
 
         $this->assertSame([
             11 => 'Larry Casper',
@@ -131,7 +139,12 @@ public function testItCanUsePaginatedSearch()
 
     public function testItCanUsePaginatedSearchWithQueryCallback()
     {
-        [$page1, $page2] = $this->itCanUsePaginatedSearchWithQueryCallback();
+        $queryCallback = function ($query) {
+            return $query->whereNotNull('email_verified_at');
+        };
+
+        $page1 = SqlUser::search('lar')->take(10)->query($queryCallback)->paginate(3, 'page', 1);
+        $page2 = SqlUser::search('lar')->take(10)->query($queryCallback)->paginate(3, 'page', 2);
 
         $this->assertSame([
             42 => 'Dax Larkin',
@@ -142,14 +155,4 @@ public function testItCanUsePaginatedSearchWithQueryCallback()
             44 => 'Amos Larson Sr.',
         ], $page2->pluck('name', 'id')->all());
     }
-
-    protected static function scoutDriver(): string
-    {
-        return 'mongodb';
-    }
-
-    protected function getUserModel(): string
-    {
-        return SqlUser::class;
-    }
 }

tests/Scout/SearchableTests.php

@@ -13,6 +13,9 @@
 
 class TestCase extends OrchestraTestCase
 {
+    /** @var class-string */
+    protected static string $userModel = User::class;
+
     /**
      * Get package providers.
      *
@@ -48,7 +51,7 @@ protected function getEnvironmentSetUp($app): void
         $app['config']->set('database.connections.mongodb2', $config['connections']['mongodb']);
 
         $app['config']->set('auth.model', User::class);
-        $app['config']->set('auth.providers.users.model', static::getUserModel());
+        $app['config']->set('auth.providers.users.model', self::$userModel);
         $app['config']->set('cache.driver', 'array');
 
         $app['config']->set('cache.stores.mongodb', [
@@ -70,10 +73,4 @@ protected function getEnvironmentSetUp($app): void
         $app['config']->set('scout.driver', 'mongodb');
         $app['config']->set('scout.prefix', 'scout_');
     }
-
-    /** @return class-string<\Illuminate\Foundation\Auth\User> */
-    protected function getUserModel(): string
-    {
-        return User::class;
-    }
 }