remove AUTHSOURCE: thisDB, remove logs

Author: kevinAlbs

.evergreen/config.yml

@@ -26565,7 +26565,6 @@ tasks:
       SSL: ssl
       TOPOLOGY: sharded_cluster
       VERSION: '5.0'
-      AUTHSOURCE: thisDB
   - func: clone drivers-evergreen-tools
   - func: start load balancer
     vars:
@@ -26593,7 +26592,6 @@ tasks:
       SSL: ssl
       TOPOLOGY: sharded_cluster
       VERSION: latest
-      AUTHSOURCE: thisDB
   - func: clone drivers-evergreen-tools
   - func: start load balancer
     vars:

CONTRIBUTING.md

@@ -265,8 +265,8 @@ This will ensure that all tests declare the indicated API version when connectin
 To test a load balanced deployment, set the following environment variables:
 
 * `MONGOC_TEST_LOADBALANCED=on`
-* `SINGLE_MONGOS_LB_URI=<string>` to a load balancer fronting one mongos.
-* `MULTI_MONGOS_LB_URI=<string>` to a load balancer fronting multiple mongos processes.
+* `SINGLE_MONGOS_LB_URI=<string>` to a MongoDB URI with a host of a load balancer fronting one mongos.
+* `MULTI_MONGOS_LB_URI=<string>` to a MongoDB URI with a host of a load balancer fronting multiple mongos processes.
 
 All tests should pass before submitting a patch.
 

build/evergreen_config_lib/tasks.py

@@ -1128,8 +1128,6 @@ def to_dict(self):
                                   AUTH='auth' if self.test_auth else 'noauth',
                                   SSL='ssl' if self.test_ssl else 'nossl',
                                   VERSION=self.version)
-        if self.test_auth:
-            orchestration['vars']['AUTHSOURCE'] = 'thisDB'
         commands.append(orchestration)
         commands.append (func("clone drivers-evergreen-tools"))
         commands.append (func("start load balancer",

src/libmongoc/src/mongoc/mongoc-server-description.c

@@ -737,7 +737,7 @@ mongoc_server_description_handle_hello (mongoc_server_description_t *sd,
       }
    }
 
-   
+
    if (global_mock_service_id) {
       bson_iter_t pid_iter;
 

src/libmongoc/tests/json-test.c

@@ -784,7 +784,6 @@ check_version_info (const bson_t *scenario, bool print_reason)
 
       /* Determine cluster type */
       if (test_framework_is_loadbalanced()) {
-         MONGOC_DEBUG ("TOPOLOGY detected as load-balanced from env variable");
          current_topology = "load-balanced";
       } else if (test_framework_is_mongos ()) {
          current_topology = "sharded";
@@ -1744,7 +1743,6 @@ run_json_general_test (const json_test_config_t *config)
       }
 
       client = test_framework_client_new_from_uri (uri, NULL);
-      MONGOC_DEBUG ("client is using uri: %s", mongoc_uri_get_string (uri));
       mongoc_client_set_error_api (client, MONGOC_ERROR_API_VERSION_2);
       test_framework_set_ssl_opts (client);
       /* reconnect right away, if a fail point causes a disconnect */

src/libmongoc/tests/json-test.h

@@ -44,13 +44,14 @@ typedef struct _json_test_config_t {
    bool command_started_events_only;
    bool command_monitoring_allow_subset;
    const char *uri_str;
-   /* skips is a NULL terminated list of tests to skip identified by the test "description" */
+   /* skips is a NULL terminated list of tests to skip identified by the test
+    * "description" */
    test_skip_t *skips;
 } json_test_config_t;
 
 
-#define JSON_TEST_CONFIG_INIT                                \
-   {                                                         \
+#define JSON_TEST_CONFIG_INIT                                      \
+   {                                                               \
       NULL, NULL, NULL, NULL, NULL, NULL, false, false, NULL, NULL \
    }
 

src/libmongoc/tests/test-mongoc-retryable-writes.c

@@ -33,9 +33,9 @@ retryable_writes_test_run_operation (json_test_ctx_t *ctx,
 
 
 static test_skip_t skips[] = {
-   {"InsertOne fails after multiple retryable writeConcernErrors", "Waiting on CDRIVER-3790" },
-   {0, 0}
-};
+   {"InsertOne fails after multiple retryable writeConcernErrors",
+    "Waiting on CDRIVER-3790"},
+   {0, 0}};
 
 /* Callback for JSON tests from Retryable Writes Spec */
 static void
@@ -127,7 +127,8 @@ test_rs_failover (void)
 
 
 /* Test code paths for _mongoc_client_command_with_opts.
- * This test requires a 3.6+ replica set to support the onPrimaryTransactionalWrite failpoint. */
+ * This test requires a 3.6+ replica set to support the
+ * onPrimaryTransactionalWrite failpoint. */
 static void
 test_command_with_opts (void *ctx)
 {

src/libmongoc/tests/unified/entity-map.c

@@ -1151,7 +1151,7 @@ entity_map_add_changestream (entity_map_t *em,
       em, id, "changestream", (void *) changestream, error);
 }
 
-bool
+void
 entity_findcursor_iterate_until_document_or_error (
    entity_findcursor_t *findcursor,
    const bson_t **document,
@@ -1163,16 +1163,15 @@ entity_findcursor_iterate_until_document_or_error (
    if (findcursor->first_result) {
       *document = findcursor->first_result;
       findcursor->first_result = NULL;
-      return true;
+      return;
    }
 
    while (!mongoc_cursor_next (findcursor->cursor, document)) {
       if (mongoc_cursor_error_document (
              findcursor->cursor, error, error_document)) {
-         return false;
+         return;
       }
    }
-   return true;
 }
 
 bool

src/libmongoc/tests/unified/entity-map.h

@@ -48,13 +48,6 @@ typedef struct _entity_t {
 struct _entity_findcursor_t;
 typedef struct _entity_findcursor_t entity_findcursor_t;
 
-bool
-entity_findcursor_iterate_until_document_or_error (
-   entity_findcursor_t *cursor,
-   const bson_t **document,
-   bson_error_t *error,
-   const bson_t **error_document);
-
 /* Operations on the entity map enforce:
  * 1. Uniqueness. Attempting to create two entries with the same id is an error.
  * 2. Referential integrity. Attempting to get with an unknown id is an error.
@@ -131,6 +124,13 @@ entity_map_get_findcursor (entity_map_t *entity_map,
                            const char *id,
                            bson_error_t *error);
 
+void
+entity_findcursor_iterate_until_document_or_error (
+   entity_findcursor_t *cursor,
+   const bson_t **document,
+   bson_error_t *error,
+   const bson_t **error_document);
+
 mongoc_client_session_t *
 entity_map_get_session (entity_map_t *entity_map,
                         const char *id,

src/libmongoc/tests/unified/operation.c

@@ -688,7 +688,7 @@ operation_count_documents (test_t *test,
 }
 
 static bool
-operation_create_findcursor (test_t *test,
+operation_create_find_cursor (test_t *test,
                              operation_t *op,
                              result_t *result,
                              bson_error_t *error)
@@ -2533,7 +2533,8 @@ operation_assert_number_connections_checked_out (test_t *test,
                                                  bson_error_t *error)
 {
    /* "This operation only applies to drivers that implement connection pooling
-    * and should be skipped for drivers that do not." */
+    * and should be skipped for drivers that do not."
+    * TODO: (CDRIVER-3525) add this assertion when CMAP is implemented. */
    result_from_ok (result);
    return true;
 }
@@ -2567,7 +2568,7 @@ operation_run (test_t *test, bson_t *op_bson, bson_error_t *error)
       {"aggregate", operation_aggregate},
       {"bulkWrite", operation_bulk_write},
       {"countDocuments", operation_count_documents},
-      {"createFindCursor", operation_create_findcursor},
+      {"createFindCursor", operation_create_find_cursor},
       {"createIndex", operation_create_index},
       {"deleteOne", operation_delete_one},
       {"deleteMany", operation_delete_many},

src/libmongoc/tests/unified/runner.c

@@ -73,8 +73,9 @@ skipped_unified_test_t SKIPPED_TESTS[] = {
    {"assertNumberConnectionsCheckedOut", SKIP_ALL_TESTS},
    {"entity-client-cmap-events", SKIP_ALL_TESTS},
    {"expectedEventsForClient-eventType", SKIP_ALL_TESTS},
-   /* CDRIVER-????: File a ticket to support batchSize on listCollections and listIndexes. Prefer this waits until a cursor specification (DRIVERS-722). */
+   /* CDRIVER-4115: listCollections does not support batchSize. */
    {"cursors are correctly pinned to connections for load-balanced clusters", "listCollections pins the cursor to a connection"},
+   /* CDRIVER-4116: listIndexes does not support batchSize. */
    {"cursors are correctly pinned to connections for load-balanced clusters", "listIndexes pins the cursor to a connection"},
    /* libmongoc does not pin connections to cursors. It cannot force an error from waitQueueTimeoutMS by creating cursors in load balanced mode. */
    {"wait queue timeout errors include details about checked out connections", SKIP_ALL_TESTS},
@@ -381,7 +382,7 @@ test_runner_new (void)
    /* In load balanced mode, the internal client must use the SINGLE_LB_MONGOS_URI. */
    if (!test_framework_is_loadbalanced ()) {
       /* Always use multiple mongos's if speaking to a mongos.
-      * Some test operations require communicating with all known mongos */
+       * Some test operations require communicating with all known mongos */
       if (!test_framework_uri_apply_multi_mongos (uri, true, &error)) {
          test_error ("error applying multiple mongos: %s", error.message);
       }
@@ -1146,7 +1147,8 @@ test_check_expected_events_for_client (test_t *test,
 
    if (event_type) {
       if (0 == strcmp (event_type, "cmap")) {
-         /* Explicitly ignore cmap events. These are unsupported by the C driver */
+         /* TODO: (CDRIVER-3525) Explicitly ignore cmap events until CMAP is
+          * supported. */
          ret = true;
          goto done;
       } else if (0 == strcmp (event_type, "command")) {
@@ -1609,6 +1611,7 @@ run_one_test_file (bson_t *bson)
    test_file = test_file_new (test_runner, bson);
 
    test_diagnostics_test_info ("test file: %s", test_file->description);
+
    if (is_test_file_skipped (test_file)) {
       MONGOC_DEBUG (
          "SKIPPING test file '%s'. Reason: 'explicitly skipped in runner.c'",

src/libmongoc/tests/unified/util.c

@@ -164,6 +164,8 @@ test_bson_util_install (TestSuite *suite)
       suite, "/unified/selftest/util/copy_and_sort", test_copy_and_sort);
 }
 
+/* TODO (CDRIVER-3525) add test support for CMAP events once the C driver
+ * supports CMAP. */
 bool is_unsupported_event_type (const char* event_type) {
    char * unsupported_event_types[] = {
       "poolCreatedEvent",