Fix issues from code review

Author: alcaeus

src/libmongoc/doc/mongoc_server_description_ismaster.rst

@@ -29,7 +29,7 @@ Parameters
 Description
 -----------
 
-The client or client pool periodically runs a `"hello" <https://docs.mongodb.org/manual/reference/command/isMaster/>`_ command on each server, to update its view of the MongoDB deployment. Use :symbol:`mongoc_client_get_server_descriptions()` and ``mongoc_server_description_hello()`` to get the most recent "hello" response.
+The client or client pool periodically runs a `"hello" <https://docs.mongodb.org/manual/reference/command/hello/>`_ command on each server, to update its view of the MongoDB deployment. Use :symbol:`mongoc_client_get_server_descriptions()` and ``mongoc_server_description_hello()`` to get the most recent "hello" response.
 
 Returns
 -------

src/libmongoc/src/mongoc/mongoc-error-private.h

@@ -44,14 +44,11 @@ typedef enum {
    MONGOC_SERVER_ERR_RETRYCHANGESTREAM = 234,
    MONGOC_SERVER_ERR_EXCEEDEDTIMELIMIT = 262,
    MONGOC_SERVER_ERR_SOCKETEXCEPTION = 9001,
-   MONGOC_SERVER_ERR_NOTMASTER = 10107,
    MONGOC_SERVER_ERR_NOTPRIMARY = 10107,
    MONGOC_SERVER_ERR_INTERRUPTEDATSHUTDOWN = 11600,
    MONGOC_SERVER_ERR_INTERRUPTEDDUETOREPLSTATECHANGE = 11602,
    MONGOC_SERVER_ERR_STALECONFIG = 13388,
-   MONGOC_SERVER_ERR_NOTMASTERNOSLAVEOK = 13435,
    MONGOC_SERVER_ERR_NOTPRIMARYNOSECONDARYOK = 13435,
-   MONGOC_SERVER_ERR_NOTMASTERORSECONDARY = 13436,
    MONGOC_SERVER_ERR_NOTPRIMARYORSECONDARY = 13436,
    MONGOC_SERVER_ERR_LEGACYNOTPRIMARY = 10058
 } mongoc_server_err_t;

src/libmongoc/src/mongoc/mongoc-interrupt-private.h

@@ -24,7 +24,7 @@
 /* Creates a stream to use to interrupt calls to mongoc_stream_poll.
  *
  * The expected use is to cancel in-progress hello commands (especially for
- * awaitable hello). An hello command may not respond for a long time, so
+ * awaitable hello). A hello command may not respond for a long time, so
  * reading the reply may block on mongoc_stream_poll until data is readable. To
  * interrupt mongoc_stream_poll, a stream retrieved by
  * _mongoc_interrupt_get_stream can be added to the call of poll. Any other

src/libmongoc/src/mongoc/mongoc-server-description.c

@@ -562,7 +562,7 @@ mongoc_server_description_handle_hello (mongoc_server_description_t *sd,
                                   NULL);
    sd->has_hello_response = true;
 
-   /* Only reinitialize the topology version if we have an hello response.
+   /* Only reinitialize the topology version if we have a hello response.
     * Resetting a server description should not effect the topology version. */
    bson_reinit (&sd->topology_version);
 

src/libmongoc/src/mongoc/mongoc-server-monitor.c

@@ -797,7 +797,7 @@ _server_monitor_setup_connection (mongoc_server_monitor_t *server_monitor,
    RETURN (ret);
 }
 
-/* Perform an hello check of a server.
+/* Perform a hello check of a server.
  *
  * Called only by server monitor thread.
  * Caller must not hold any locks.

src/libmongoc/tests/mock_server/mock-server.c

@@ -1051,10 +1051,10 @@ mock_server_receives_legacy_hello (mock_server_t *server,
  *
  * Returns:
  *       A request you must request_destroy, or NULL if the current
- *       request is not an hello command.
+ *       request is not a hello command.
  *
  * Side effects:
- *       Logs if the current request is not an hello command.
+ *       Logs if the current request is not a hello command.
  *
  *--------------------------------------------------------------------------
  */

src/libmongoc/tests/test-mongoc-cluster.c

@@ -1076,7 +1076,7 @@ _test_not_primary (bool pooled,
       BSON_ASSERT (sd->type == MONGOC_SERVER_STANDALONE);
 
       /*
-       * command error marks server Unknown iff it's a "not primary" error
+       * command error marks server Unknown if it's a "not primary" error
        */
       future = run_command (client);
       request = mock_server_receives_request (server);