CDRIVER-3685 address TSAN warning for mongoc_handshake_t::frozen (#1698)

eramongodb · kevinAlbs · commit 2735d559c0fa · 2024-08-30T14:20:33.000-04:00
diff --git a/.tsan-suppressions b/.tsan-suppressions
@@ -1,2 +1 @@
 race:mongoc_counter*
-race:_mongoc_handshake_freeze
diff --git a/src/libmongoc/src/mongoc/mongoc-handshake.c b/src/libmongoc/src/mongoc/mongoc-handshake.c
@@ -720,7 +720,9 @@ _mongoc_handshake_build_doc_with_application (const char *appname)
 void
 _mongoc_handshake_freeze (void)
 {
+   bson_mutex_lock (&gHandshakeLock);
    _mongoc_handshake_get ()->frozen = true;
+   bson_mutex_unlock (&gHandshakeLock);
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1 @@`
`1`	`1`	`race:mongoc_counter*`
`2`		`-race:_mongoc_handshake_freeze`
Original file line number	Diff line number	Diff line change
`@@ -720,7 +720,9 @@ _mongoc_handshake_build_doc_with_application (const char *appname)`
`720`	`720`	`void`
`721`	`721`	`_mongoc_handshake_freeze (void)`
`722`	`722`	`{`
	`723`	`+ bson_mutex_lock (&gHandshakeLock);`
`723`	`724`	`_mongoc_handshake_get ()->frozen = true;`
	`725`	`+ bson_mutex_unlock (&gHandshakeLock);`
`724`	`726`	`}`
`725`	`727`
`726`	`728`	`/*`