Don't manually set TLS errors

adriandole · adriandole · commit 4c357bd51fb1 · 2024-05-08T11:50:14.000-07:00
diff --git a/src/libmongoc/src/mongoc/mongoc-crypt.c b/src/libmongoc/src/mongoc/mongoc-crypt.c
@@ -590,11 +590,7 @@ _state_need_kms (_state_machine_t *state_machine, bson_error_t *error)
                /* Always safe to retry stream creation. */
                continue;
             } else {
-               bson_set_error (error,
-                               MONGOC_ERROR_STREAM,
-                               MONGOC_ERROR_STREAM_CONNECT,
-                               "Failed to connect to KMS endpoint: %s",
-                               endpoint);
+               /* TLS errors are set in _get_stream */
                goto fail;
             }
          }

Original file line number	Diff line number	Diff line change
`@@ -590,11 +590,7 @@ _state_need_kms (_state_machine_t state_machine, bson_error_t error)`
`590`	`590`	`/* Always safe to retry stream creation. */`
`591`	`591`	`continue;`
`592`	`592`	`} else {`
`593`		`- bson_set_error (error,`
`594`		`- MONGOC_ERROR_STREAM,`
`595`		`- MONGOC_ERROR_STREAM_CONNECT,`
`596`		`- "Failed to connect to KMS endpoint: %s",`
`597`		`- endpoint);`
	`593`	`+ /* TLS errors are set in _get_stream */`
`598`	`594`	`goto fail;`
`599`	`595`	`}`
`600`	`596`	`}`