CDRIVER-2673 test to verify installed lib name

Author: ajdavis

.evergreen/check-symlink.sh

@@ -0,0 +1,25 @@
+check_symlink()
+{
+  SYMLINK="$INSTALL_DIR/lib/$1"
+  EXPECTED_TARGET="$2"
+
+  if test ! -L "$SYMLINK"; then
+    echo "$SYMLINK should be a symlink"
+    exit 1
+  fi
+
+  TARGET=$(readlink "$SYMLINK")
+  if test ! -f $INSTALL_DIR/lib/$TARGET; then
+    echo "$SYMLINK target $INSTALL_DIR/lib/$TARGET is missing!"
+    exit 1
+  else
+    echo "$SYMLINK target $INSTALL_DIR/lib/$TARGET check ok"
+  fi
+
+  if [ "$TARGET" != "$EXPECTED_TARGET" ]; then
+    echo "$SYMLINK should symlink to $EXPECTED_TARGET, not to $TARGET"
+    exit 1
+  else
+    echo "$SYMLINK links to correct filename"
+  fi
+}

.evergreen/link-sample-program-bson.sh

@@ -11,20 +11,25 @@ echo "LINK_STATIC=$LINK_STATIC BUILD_SAMPLE_WITH_CMAKE=$BUILD_SAMPLE_WITH_CMAKE"
 
 DIR=$(dirname $0)
 . $DIR/find-cmake.sh
+. $DIR/check-symlink.sh
 
 if command -v gtar 2>/dev/null; then
   TAR=gtar
 else
   TAR=tar
 fi
 
-if [ $(uname) = "Darwin" ]; then
+# Get the kernel name, lowercased
+OS=$(uname -s | tr '[:upper:]' '[:lower:]')
+echo "OS: $OS"
+
+if [ "$OS" = "darwin" ]; then
   SO=dylib
   LIB_SO=libbson-1.0.0.dylib
   LDD="otool -L"
 else
   SO=so
-  LIB_SO=libbson-1.0.so.0
+  LIB_SO=libbson-1.0.so.0.0.0
   LDD=ldd
 fi
 
@@ -76,28 +81,34 @@ else
 
 fi
 
-set +o xtrace
-
-LIB=$INSTALL_DIR/lib/libbson-1.0.$SO
-if test ! -L $LIB; then
-   echo "$LIB should be a symlink"
-   exit 1
-fi
-
-TARGET=$(readlink $LIB)
-if test ! -f $INSTALL_DIR/lib/$TARGET; then
-  echo "$LIB target $INSTALL_DIR/lib/$TARGET is missing!"
-  exit 1
-else
-  echo "$LIB target $INSTALL_DIR/lib/$TARGET check ok"
-fi
+ls -l $INSTALL_DIR/lib
 
+set +o xtrace
 
-if test ! -f $INSTALL_DIR/lib/$LIB_SO; then
-  echo "$LIB_SO missing!"
-  exit 1
+# Check on Linux that libbson is installed into lib/ like:
+# libbson-1.0.so -> libbson-1.0.so.0
+# libbson-1.0.so.0 -> libbson-1.0.so.0.0.0
+# libbson-1.0.so.0.0.0
+if [ "$OS" != "darwin" ]; then
+  # From check-symlink.sh
+  check_symlink libbson-1.0.so libbson-1.0.so.0
+  check_symlink libbson-1.0.so.0 libbson-1.0.so.0.0.0
+  SONAME=$(objdump -p $INSTALL_DIR/lib/$LIB_SO|grep SONAME|awk '{print $2}')
+  EXPECTED_SONAME="libbson-1.0.so.0"
+  if [ "$SONAME" != "$EXPECTED_SONAME" ]; then
+    echo "SONAME should be $EXPECTED_SONAME, not $SONAME"
+    exit 1
+  else
+    echo "library name check ok, SONAME=$SONAME"
+  fi
 else
-  echo "$LIB_SO check ok"
+  # Just test that the shared lib was installed.
+  if test ! -f $INSTALL_DIR/lib/$LIB_SO; then
+    echo "$LIB_SO missing!"
+    exit 1
+  else
+    echo "$LIB_SO check ok"
+  fi
 fi
 
 if test ! -f $INSTALL_DIR/lib/pkgconfig/libbson-1.0.pc; then
@@ -177,7 +188,7 @@ else
 fi
 
 if [ ! "$LINK_STATIC" ]; then
-  if [ $(uname) = "Darwin" ]; then
+  if [ "$OS" = "darwin" ]; then
     export DYLD_LIBRARY_PATH=$INSTALL_DIR/lib
   else
     export LD_LIBRARY_PATH=$INSTALL_DIR/lib

.evergreen/link-sample-program.sh

@@ -14,6 +14,7 @@ echo "LINK_STATIC=$LINK_STATIC BUILD_SAMPLE_WITH_CMAKE=$BUILD_SAMPLE_WITH_CMAKE"
 
 DIR=$(dirname $0)
 . $DIR/find-cmake.sh
+. $DIR/check-symlink.sh
 
 if command -v gtar 2>/dev/null; then
   TAR=gtar
@@ -76,29 +77,37 @@ $CMAKE -DCMAKE_INSTALL_PREFIX=$INSTALL_DIR -DCMAKE_PREFIX_PATH=$INSTALL_DIR/lib/
 make
 make install
 
-
-LIB=$INSTALL_DIR/lib/libmongoc-1.0.$SO
-if test ! -L $LIB; then
-   echo "$LIB should be a symlink"
-   exit 1
-fi
-
-TARGET=$(readlink $LIB)
-if test ! -f $INSTALL_DIR/lib/$TARGET; then
-  echo "$LIB target $INSTALL_DIR/lib/$TARGET is missing!"
-  exit 1
+ls -l $INSTALL_DIR/lib
+
+set +o xtrace
+
+# Check on Linux that libmongoc is installed into lib/ like:
+# libmongoc-1.0.so -> libmongoc-1.0.so.0
+# libmongoc-1.0.so.0 -> libmongoc-1.0.so.0.0.0
+# libmongoc-1.0.so.0.0.0
+if [ "$OS" != "darwin" ]; then
+  # From check-symlink.sh
+  check_symlink libmongoc-1.0.so libmongoc-1.0.so.0
+  check_symlink libmongoc-1.0.so.0 libmongoc-1.0.so.0.0.0
+  SONAME=$(objdump -p $INSTALL_DIR/lib/$LIB_SO|grep SONAME|awk '{print $2}')
+  EXPECTED_SONAME="libmongoc-1.0.so.0"
+  if [ "$SONAME" != "$EXPECTED_SONAME" ]; then
+    echo "SONAME should be $EXPECTED_SONAME, not $SONAME"
+    exit 1
+  else
+    echo "library name check ok, SONAME=$SONAME"
+  fi
 else
-  echo "$LIB target $INSTALL_DIR/lib/$TARGET check ok"
+  # Just test that the shared lib was installed.
+  if test ! -f $INSTALL_DIR/lib/$LIB_SO; then
+    echo "$LIB_SO missing!"
+    exit 1
+  else
+    echo "$LIB_SO check ok"
+  fi
 fi
 
 
-if test ! -f $INSTALL_DIR/lib/$LIB_SO; then
-  echo "$LIB_SO missing!"
-  exit 1
-else
-  echo "$LIB_SO check ok"
-fi
-
 if test ! -f $INSTALL_DIR/lib/pkgconfig/libmongoc-1.0.pc; then
   echo "libmongoc-1.0.pc missing!"
   exit 1
@@ -167,7 +176,7 @@ else
   fi
 fi
 
-if [ $(uname) = "Darwin" ]; then
+if [ "$OS" = "darwin" ]; then
   if test -f $INSTALL_DIR/bin/mongoc-stat; then
     echo "mongoc-stat shouldn't have been installed"
     exit 1
@@ -181,6 +190,8 @@ else
   fi
 fi
 
+set -o xtrace
+
 if [ "$BUILD_SAMPLE_WITH_CMAKE" ]; then
   # Test our CMake package config file with CMake's find_package command.
   EXAMPLE_DIR=$SRCROOT/src/libmongoc/examples/cmake/find_package
@@ -209,7 +220,7 @@ else
 fi
 
 if [ ! "$LINK_STATIC" ]; then
-  if [ $(uname) = "Darwin" ]; then
+  if [ "$OS" = "darwin" ]; then
     export DYLD_LIBRARY_PATH=$INSTALL_DIR/lib
   else
     export LD_LIBRARY_PATH=$INSTALL_DIR/lib