Allow methods in bulk_op_append to fail so expectError can be evaluated

Author: jmikola

src/libmongoc/tests/unified/operation.c

@@ -476,63 +476,53 @@ bulk_op_append (mongoc_bulk_operation_t *bulk,
       if (!bson_parser_parse (parser, &request_doc, error)) {
          goto done;
       }
-      if (!mongoc_bulk_operation_insert_with_opts (
-             bulk, document, bson_parser_get_extra (parser), error)) {
-         goto done;
-      }
+
+      mongoc_bulk_operation_insert_with_opts (
+         bulk, document, bson_parser_get_extra (parser), error);
    } else if (0 == strcmp (op_type, "updateOne")) {
       bson_parser_doc (parser, "filter", &filter);
       bson_parser_array_or_doc (parser, "update", &update);
       if (!bson_parser_parse (parser, &request_doc, error)) {
          goto done;
       }
-      if (!mongoc_bulk_operation_update_one_with_opts (
-             bulk, filter, update, bson_parser_get_extra (parser), error)) {
-         goto done;
-      }
+
+      mongoc_bulk_operation_update_one_with_opts (
+         bulk, filter, update, bson_parser_get_extra (parser), error);
    } else if (0 == strcmp (op_type, "updateMany")) {
       bson_parser_doc (parser, "filter", &filter);
       bson_parser_array_or_doc (parser, "update", &update);
       if (!bson_parser_parse (parser, &request_doc, error)) {
          goto done;
       }
-      if (!mongoc_bulk_operation_update_many_with_opts (
-             bulk, filter, update, bson_parser_get_extra (parser), error)) {
-         goto done;
-      }
+
+      mongoc_bulk_operation_update_many_with_opts (
+         bulk, filter, update, bson_parser_get_extra (parser), error);
    } else if (0 == strcmp (op_type, "deleteOne")) {
       bson_parser_doc (parser, "filter", &filter);
 
       if (!bson_parser_parse (parser, &request_doc, error)) {
          goto done;
       }
-      if (!mongoc_bulk_operation_remove_one_with_opts (
-             bulk, filter, bson_parser_get_extra (parser), error)) {
-         goto done;
-      }
+
+      mongoc_bulk_operation_remove_one_with_opts (
+         bulk, filter, bson_parser_get_extra (parser), error);
    } else if (0 == strcmp (op_type, "deleteMany")) {
       bson_parser_doc (parser, "filter", &filter);
       if (!bson_parser_parse (parser, &request_doc, error)) {
          goto done;
       }
-      if (!mongoc_bulk_operation_remove_many_with_opts (
-             bulk, filter, bson_parser_get_extra (parser), error)) {
-         goto done;
-      }
+
+      mongoc_bulk_operation_remove_many_with_opts (
+         bulk, filter, bson_parser_get_extra (parser), error);
    } else if (0 == strcmp (op_type, "replaceOne")) {
       bson_parser_doc (parser, "filter", &filter);
       bson_parser_doc (parser, "replacement", &replacement);
       if (!bson_parser_parse (parser, &request_doc, error)) {
          goto done;
       }
-      if (!mongoc_bulk_operation_replace_one_with_opts (
-             bulk,
-             filter,
-             replacement,
-             bson_parser_get_extra (parser),
-             error)) {
-         goto done;
-      }
+
+      mongoc_bulk_operation_replace_one_with_opts (
+         bulk, filter, replacement, bson_parser_get_extra (parser), error);
    }
 
    ret = true;