simplify check_schema_version

Author: kevinAlbs

src/libmongoc/tests/unified/runner.c

@@ -571,31 +571,28 @@ get_topology_type (mongoc_client_t *client)
 static void
 check_schema_version (test_file_t *test_file)
 {
-   const char *supported_version_strs[] = {
-      "1.8",  /* fully supported through this version */
-      "1.12", /* partially supported (expectedError.errorResponse assertions) */
-      "1.18"  /* partially supported (additional properties in kmsProviders) */
-      "1.20"  /* partially supported (expectedError.writeErrors and
-                 expectedError.writeConcernErrors) */
-   };
-   int i;
-
-   for (i = 0; i < sizeof (supported_version_strs) / sizeof (supported_version_strs[0]); i++) {
-      semver_t supported_version;
-
-      semver_parse (supported_version_strs[i], &supported_version);
-      if (supported_version.major != test_file->schema_version.major) {
-         continue;
-      }
-      if (!supported_version.has_minor) {
-         /* All minor versions for this major version are supported. */
-         return;
-      }
-      if (supported_version.minor >= test_file->schema_version.minor) {
-         return;
-      }
+   // `schema_version` is the latest schema version the test runner will try to run.
+   // 1.8 is fully supported. Later minor versions are partially supported.
+   // 1.12 is partially supported (expectedError.errorResponse assertions)
+   // 1.18 is partially supported (additional properties in kmsProviders)
+   // 1.20 is partially supported (expectedError.writeErrors and expectedError.writeConcernErrors)
+   semver_t schema_version;
+   semver_parse ("1.20", &schema_version);
+
+   if (schema_version.major != test_file->schema_version.major) {
+      goto fail;
+   }
+
+   if (!schema_version.has_minor) {
+      /* All minor versions for this major version are supported. */
+      return;
+   }
+
+   if (schema_version.minor >= test_file->schema_version.minor) {
+      return;
    }
 
+fail:
    test_error ("Unsupported schema version: %s", semver_to_string (&test_file->schema_version));
 }