CDRIVER-4155 address deadStore warnings (#866)

Author: kevinAlbs

src/libbson/src/bson/bson-decimal128.c

@@ -709,8 +709,6 @@ bson_decimal128_from_string_w_len (const char *string,     /* IN */
    }
 
    /* Encode significand */
-   significand_high = 0,   /* The high 17 digits of the significand */
-      significand_low = 0; /* The low 17 digits of the significand */
 
    if (significant_digits == 0) { /* read a zero */
       significand_high = 0;

src/libmongoc/tests/mock_server/mock-rs.c

@@ -321,7 +321,6 @@ mock_rs_run (mock_rs_t *rs)
 {
    int i;
    mock_server_t *server;
-   char *hosts_str;
    char *hello;
 
    if (rs->has_primary) {
@@ -368,7 +367,7 @@ mock_rs_run (mock_rs_t *rs)
 
 
    /* now we know all servers' ports and we have them in one array */
-   rs->hosts_str = hosts_str = hosts (&rs->servers);
+   rs->hosts_str = hosts (&rs->servers);
    rs->uri = make_uri (&rs->servers);
 
    BSON_ASSERT (rs->max_wire_version > 0);

src/libmongoc/tests/test-mongoc-rpc.c

@@ -481,7 +481,6 @@ test_mongoc_rpc_reply_scatter2 (void)
    bson_reader_t *reader;
    uint8_t *data;
    mongoc_rpc_t rpc;
-   const bson_t *b;
    bool r;
    bool eof = false;
    bson_t empty;
@@ -508,7 +507,7 @@ test_mongoc_rpc_reply_scatter2 (void)
    ASSERT (rpc.reply.documents_len == 16200);
    reader =
       bson_reader_new_from_data (rpc.reply.documents, rpc.reply.documents_len);
-   while ((b = bson_reader_read (reader, &eof))) {
+   while (bson_reader_read (reader, &eof)) {
       count++;
    }
    ASSERT (eof == true);