Code review fixes

alcaeus · alcaeus · commit f149b68eb2af · 2021-03-19T09:32:50.000+01:00
diff --git a/src/libmongoc/src/mongoc/mongoc-cmd.c b/src/libmongoc/src/mongoc/mongoc-cmd.c
@@ -1150,6 +1150,7 @@ _mongoc_cmd_append_payload_as_array (const mongoc_cmd_t *cmd, bson_t *out)
  *
  * Pre-conditions:
  *    - @api is initialized.
+ *    - @command_body is initialised
  *
  *--------------------------------------------------------------------------
  */
@@ -1159,6 +1160,7 @@ _mongoc_cmd_append_server_api (bson_t *command_body,
 {
    const char *string_version;
 
+   BSON_ASSERT (command_body);
    BSON_ASSERT (api);
 
    string_version = mongoc_server_api_version_to_string (api->version);
diff --git a/src/libmongoc/tests/test-mongoc-topology.c b/src/libmongoc/tests/test-mongoc-topology.c
@@ -2218,7 +2218,7 @@ _test_ismaster_versioned_api (bool pooled)
    mock_server_run (server);
    uri = mongoc_uri_copy (mock_server_get_uri (server));
 
-   mongoc_server_api_version_from_string ("1", &version);
+   BSON_ASSERT (mongoc_server_api_version_from_string ("1", &version));
    api = mongoc_server_api_new (version);
 
    if (pooled) {

Original file line number	Diff line number	Diff line change
`@@ -1150,6 +1150,7 @@ _mongoc_cmd_append_payload_as_array (const mongoc_cmd_t cmd, bson_t out)`
`1150`	`1150`	`*`
`1151`	`1151`	`* Pre-conditions:`
`1152`	`1152`	`* - @api is initialized.`
	`1153`	`+ * - @command_body is initialised`
`1153`	`1154`	`*`
`1154`	`1155`	`*--------------------------------------------------------------------------`
`1155`	`1156`	`*/`
`@@ -1159,6 +1160,7 @@ _mongoc_cmd_append_server_api (bson_t *command_body,`
`1159`	`1160`	`{`
`1160`	`1161`	`const char *string_version;`
`1161`	`1162`
	`1163`	`+ BSON_ASSERT (command_body);`
`1162`	`1164`	`BSON_ASSERT (api);`
`1163`	`1165`
`1164`	`1166`	`string_version = mongoc_server_api_version_to_string (api->version);`